Chemistry
  1. Chemistry
  2. CMIS-483

URLEncoder for getObjectByPath with folder name like CARÈ CARLA

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: OpenCMIS 0.5.0
    • Fix Version/s: None
    • Labels:

      Description

      What do you think about this patch?

      ### Eclipse Workspace Patch 1.0
      #P chemistry-opencmis-client-bindings
      Index: src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java
      ===================================================================
      --- src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java	(revisione 1124118)
      +++ src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java	(copia locale)
      @@ -68,6 +68,7 @@
           private final Cache templateCache;
           private final Cache repositoryLinkCache;
       
      +    private final String encoding;
           /**
            * Constructor.
            */
      @@ -87,6 +88,8 @@
                   objCount = CACHE_SIZE_OBJECTS;
               }
       
      +        encoding = (String) session.get(SessionParameter.LOCALE_VARIANT, "UTF-8");
      +        
               linkCache = new CacheImpl("Link Cache");
               linkCache.initialize(new String[] {
                       MapCacheLevelImpl.class.getName() + " " + MapCacheLevelImpl.CAPACITY + "=" + repCount, // repository
      @@ -257,7 +260,7 @@
                           String paramValue = UrlBuilder.normalizeParameter(parameters.get(param.toString()));
                           if (paramValue != null) {
                               try {
      -                            result.append(URLEncoder.encode(paramValue, "UTF-8"));
      +                            result.append(URLEncoder.encode(paramValue, encoding));
                               } catch (UnsupportedEncodingException e) {
                                   result.append(paramValue);
                               }
      

        Activity

        Marco Spasiano created issue -
        Florent Guillaume made changes -
        Field Original Value New Value
        Description What do you think about this patch?

        ### Eclipse Workspace Patch 1.0
        #P chemistry-opencmis-client-bindings
        Index: src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java
        ===================================================================
        --- src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java (revisione 1124118)
        +++ src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java (copia locale)
        @@ -68,6 +68,7 @@
             private final Cache templateCache;
             private final Cache repositoryLinkCache;
         
        + private final String encoding;
             /**
              * Constructor.
              */
        @@ -87,6 +88,8 @@
                     objCount = CACHE_SIZE_OBJECTS;
                 }
         
        + encoding = (String) session.get(SessionParameter.LOCALE_VARIANT, "UTF-8");
        +
                 linkCache = new CacheImpl("Link Cache");
                 linkCache.initialize(new String[] {
                         MapCacheLevelImpl.class.getName() + " " + MapCacheLevelImpl.CAPACITY + "=" + repCount, // repository
        @@ -257,7 +260,7 @@
                             String paramValue = UrlBuilder.normalizeParameter(parameters.get(param.toString()));
                             if (paramValue != null) {
                                 try {
        - result.append(URLEncoder.encode(paramValue, "UTF-8"));
        + result.append(URLEncoder.encode(paramValue, encoding));
                                 } catch (UnsupportedEncodingException e) {
                                     result.append(paramValue);
                                 }
        What do you think about this patch?

        {noformat}
        ### Eclipse Workspace Patch 1.0
        #P chemistry-opencmis-client-bindings
        Index: src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java
        ===================================================================
        --- src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java (revisione 1124118)
        +++ src/main/java/org/apache/chemistry/opencmis/client/bindings/spi/atompub/LinkCache.java (copia locale)
        @@ -68,6 +68,7 @@
             private final Cache templateCache;
             private final Cache repositoryLinkCache;
         
        + private final String encoding;
             /**
              * Constructor.
              */
        @@ -87,6 +88,8 @@
                     objCount = CACHE_SIZE_OBJECTS;
                 }
         
        + encoding = (String) session.get(SessionParameter.LOCALE_VARIANT, "UTF-8");
        +
                 linkCache = new CacheImpl("Link Cache");
                 linkCache.initialize(new String[] {
                         MapCacheLevelImpl.class.getName() + " " + MapCacheLevelImpl.CAPACITY + "=" + repCount, // repository
        @@ -257,7 +260,7 @@
                             String paramValue = UrlBuilder.normalizeParameter(parameters.get(param.toString()));
                             if (paramValue != null) {
                                 try {
        - result.append(URLEncoder.encode(paramValue, "UTF-8"));
        + result.append(URLEncoder.encode(paramValue, encoding));
                                 } catch (UnsupportedEncodingException e) {
                                     result.append(paramValue);
                                 }
        {noformat}
        Florian Müller made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Marco Spasiano
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development