[CLOUDSTACK-9756] IP address must not be allocated to other VR if releasing ip address is failed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.10.0.0
• Component/s: Network Controller
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Jayapal
• Reporter: Jayapal
• Created: 25/Jan/17 05:17
• Updated: 25/May/17 10:23
• Resolved: 25/May/17 10:23

Description

Apply rule (delete) is success on failure of ip assoc on back end. Cloudstack ignored the ip assoc failure.
Due to this the ip got freed and assigned to another network/account. It caused the ip to be present in more than one router.

Fix: Failing the apply rule (delete) on ipassoc failure

Repro steps:
1. Configure PF/static nat/Firewall rules
2. Delete the rule configured.
On deleting the rule, fail the ip assoc on the router.
3. Delete rule fails because ip assoc got failed.

For RVR:
1. acquire several public ips,
2. add some rules on those public ips, so ips should show up in RVR,
3. change ipassoc.sh in RVR, make it always returns error on disassociate ip.
4. disassociate ip from UI, ip should is freed even though disassociate fails inside VR.

Issue Links

• links to: GitHub Pull Request #1917