[CLOUDSTACK-9738] Optimize vm expunge process for instances with vm snapshots

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.10.0.0
• Fix Version/s: 4.10.0.0
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Nicolas Vazquez
• Reporter: Nicolas Vazquez
• Created: 13/Jan/17 13:48
• Updated: 02/Mar/17 20:15
• Resolved: 02/Mar/17 20:15

Description

Description

It was noticed that expunging instances with many vm snapshots took a look of time, as hypervisor received as many tasks as vm snapshots instance had, apart from the delete vm task. We propose a way to optimize this process for instances with vm snapshots by sending only one delete task to hypervisor, which will delete vm and its snapshots

Use cases

1. deleteVMsnapohsot-> no changes to current behavior
2. destroyVM with expunge=false -> no actions to VMsnaphsot is performed at the moment. When VM cleanup thread is executed it will perform the same sequence as #3. If instance is recovered before expunged by the cleanup thread it will remain intact with VMSnapshot chain present
3. destroyVM with expunge=true:
   • Vmsnaphsot is marked with removed timestamp and state = Expunging in DB
   • VM is deleted in HW

Issue Links

• links to: GitHub Pull Request #1905