[CLOUDSTACK-9354] Problem creating template from snapshot via Marvin

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.9.0
• Fix Version/s: 4.9.0
• Component/s: marvin
• Security Level: Public (Anyone can view this level - this is the default.)
• Environment: N/A
• Assignee: Mike Tutkowski
• Reporter: Mike Tutkowski
• Created: 18/Apr/16 17:54
• Updated: 22/Apr/16 05:20
• Resolved: 22/Apr/16 05:13

Description

From an e-mail I sent to dev@ on April 14, 2016:

Hi,

I noticed an issue in Marvin the other day and I tracked it to this commit:

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d

The problem is that it assumes the "ispublic" parameter will be provided. If it is not, then an exception is thrown.

I think we want code more like this:

if "ispublic" in services:
cmd.ispublic = services["ispublic"]

I don't think we would want to require the "ispublic" parameter in Marvin. It's not required in our API:

http://cloudstack.apache.org/api/apidocs-4.8/root_admin/createTemplate.html​

Unless someone can think of a reason why this part of the code is the way it is now, I plan to open a PR to fix this soon.

Thanks,
Mike