Uploaded image for project: 'CloudStack'
  1. CloudStack
  2. CLOUDSTACK-9037

interface prefixes are not really prefixes in libvirtcomputeresource

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7.0
    • Component/s: KVM
    • Security Level: Public (Anyone can view this level - this is the default.)
    • Labels:
      None

      Description

      the patterns that are matched don't contain "^" which can lead to strange matches.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cloudstack/pull/1035

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1035
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3358d6509bc107bec64a58a024621cde8ee61e0b in cloudstack's branch refs/heads/master from Remi Bergsma
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3358d65 ]

          Merge pull request #1035 from DaanHoogland/CLOUDSTACK-9037

          CLOUDSTACK-9037 patterns can be more elaborate then prefixes.little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine"

          Signed-off-by: Remi Bergsma <github@remi.nl>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3358d6509bc107bec64a58a024621cde8ee61e0b in cloudstack's branch refs/heads/master from Remi Bergsma [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3358d65 ] Merge pull request #1035 from DaanHoogland/ CLOUDSTACK-9037 CLOUDSTACK-9037 patterns can be more elaborate then prefixes.little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine" pr/1035: CLOUDSTACK-9037 patterns can be more elaborate then prefixes. Signed-off-by: Remi Bergsma <github@remi.nl>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3358d6509bc107bec64a58a024621cde8ee61e0b in cloudstack's branch refs/heads/master from Remi Bergsma
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3358d65 ]

          Merge pull request #1035 from DaanHoogland/CLOUDSTACK-9037

          CLOUDSTACK-9037 patterns can be more elaborate then prefixes.little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine"

          Signed-off-by: Remi Bergsma <github@remi.nl>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3358d6509bc107bec64a58a024621cde8ee61e0b in cloudstack's branch refs/heads/master from Remi Bergsma [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3358d65 ] Merge pull request #1035 from DaanHoogland/ CLOUDSTACK-9037 CLOUDSTACK-9037 patterns can be more elaborate then prefixes.little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine" pr/1035: CLOUDSTACK-9037 patterns can be more elaborate then prefixes. Signed-off-by: Remi Bergsma <github@remi.nl>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3358d6509bc107bec64a58a024621cde8ee61e0b in cloudstack's branch refs/heads/master from Remi Bergsma
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3358d65 ]

          Merge pull request #1035 from DaanHoogland/CLOUDSTACK-9037

          CLOUDSTACK-9037 patterns can be more elaborate then prefixes.little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine"

          Signed-off-by: Remi Bergsma <github@remi.nl>

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3358d6509bc107bec64a58a024621cde8ee61e0b in cloudstack's branch refs/heads/master from Remi Bergsma [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3358d65 ] Merge pull request #1035 from DaanHoogland/ CLOUDSTACK-9037 CLOUDSTACK-9037 patterns can be more elaborate then prefixes.little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine" pr/1035: CLOUDSTACK-9037 patterns can be more elaborate then prefixes. Signed-off-by: Remi Bergsma <github@remi.nl>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 08eb96776a7714a40bab447f31862ab68f5729d7 in cloudstack's branch refs/heads/master from Daan Hoogland
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=08eb967 ]

          CLOUDSTACK-9037 patterns can be more elaborate then prefixes.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 08eb96776a7714a40bab447f31862ab68f5729d7 in cloudstack's branch refs/heads/master from Daan Hoogland [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=08eb967 ] CLOUDSTACK-9037 patterns can be more elaborate then prefixes.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user DaanHoogland commented on the pull request:

          https://github.com/apache/cloudstack/pull/1035#issuecomment-159179464

          [1035.network.results.txt](https://github.com/apache/cloudstack/files/42442/1035.network.results.txt)
          [1035.vpc.results.txt](https://github.com/apache/cloudstack/files/42443/1035.vpc.results.txt)

          @remibergsma @karuturi simple fix, can you merge?

          Show
          githubbot ASF GitHub Bot added a comment - Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1035#issuecomment-159179464 [1035.network.results.txt] ( https://github.com/apache/cloudstack/files/42442/1035.network.results.txt ) [1035.vpc.results.txt] ( https://github.com/apache/cloudstack/files/42443/1035.vpc.results.txt ) @remibergsma @karuturi simple fix, can you merge?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bhaisaab commented on the pull request:

          https://github.com/apache/cloudstack/pull/1035#issuecomment-158875017

          LGTM

          Show
          githubbot ASF GitHub Bot added a comment - Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1035#issuecomment-158875017 LGTM
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user ustcweizhou commented on the pull request:

          https://github.com/apache/cloudstack/pull/1035#issuecomment-154019836

          tested. LGTM

          Show
          githubbot ASF GitHub Bot added a comment - Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1035#issuecomment-154019836 tested. LGTM
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user DaanHoogland opened a pull request:

          https://github.com/apache/cloudstack/pull/1035

          CLOUDSTACK-9037 patterns can be more elaborate then prefixes.

          little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine"

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9037

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cloudstack/pull/1035.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1035


          commit 57ea4506e1f84174a8fb53e70d4901f2a4bb7c24
          Author: Daan Hoogland <daan@onecht.net>
          Date: 2015-11-05T09:49:17Z

          CLOUDSTACK-9037 patterns can be more elaborate then prefixes.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1035 CLOUDSTACK-9037 patterns can be more elaborate then prefixes. little fix to make sure for instance "eth" is not regarded as interface when it is part of "methamfetamine" You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CLOUDSTACK-9037 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1035.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1035 commit 57ea4506e1f84174a8fb53e70d4901f2a4bb7c24 Author: Daan Hoogland <daan@onecht.net> Date: 2015-11-05T09:49:17Z CLOUDSTACK-9037 patterns can be more elaborate then prefixes.
          Hide
          dahn Daan Hoogland added a comment -

          prepending the "^" and renaming the array name to make sure it is seen as a list of patterns instead of prefixes.

          Show
          dahn Daan Hoogland added a comment - prepending the "^" and renaming the array name to make sure it is seen as a list of patterns instead of prefixes.

            People

            • Assignee:
              dahn Daan Hoogland
              Reporter:
              dahn Daan Hoogland
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development