Uploaded image for project: 'CloudStack'
  1. CloudStack
  2. CLOUDSTACK-8838

[KVM] agent setup failed when physical interface name is in ensX format (CentOS7)

    Details

      Description

      [KVM] agent setup failed when physical interface name is in ensX format (CentOS7)

      My environment:
      CloudStack 4.5.2 (http://packages.shapeblue.com/cloudstack/upstream/centos7/4.5)
      CentOS 7.1.1503 / KVM
      mariadb-5.5.44-1

      management.log:

      2015-09-12 08:19:41,930 WARN [o.a.c.alerts] (AgentConnectTaskPool-2:ctx-4925d5ec) alertType:: 7 // dataCenterId:: 1 // podId:: 1 // clusterId:: null // message:: Incorrect Network setup on agent, Reinitialize agent after network names are setup, details : Can not find network: cloudbr1

      [root@acs ~]# ip a
      1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN
      link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
      inet 127.0.0.1/8 scope host lo
      valid_lft forever preferred_lft forever
      inet6 ::1/128 scope host
      valid_lft forever preferred_lft forever
      2: ens32: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master cloudbr0 state UP qlen 1000
      link/ether 00:0c:29:a9:09:3f brd ff:ff:ff:ff:ff:ff
      inet6 fe80::20c:29ff:fea9:93f/64 scope link
      valid_lft forever preferred_lft forever
      3: ens33: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master cloudbr1 state UP qlen 1000
      link/ether 00:0c:29:a9:09:49 brd ff:ff:ff:ff:ff:ff
      inet6 fe80::20c:29ff:fea9:949/64 scope link
      valid_lft forever preferred_lft forever
      4: cloudbr0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP
      link/ether 00:0c:29:a9:09:3f brd ff:ff:ff:ff:ff:ff
      inet 10.0.0.30/24 brd 10.0.0.255 scope global cloudbr0
      valid_lft forever preferred_lft forever
      inet6 fe80::20c:29ff:fea9:93f/64 scope link
      valid_lft forever preferred_lft forever
      5: cloudbr1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP
      link/ether 00:0c:29:a9:09:49 brd ff:ff:ff:ff:ff:ff
      inet6 fe80::20c:29ff:fea9:949/64 scope link
      valid_lft forever preferred_lft forever
      6: virbr0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN
      link/ether 52:54:00:99:14:38 brd ff:ff:ff:ff:ff:ff
      inet 192.168.122.1/24 brd 192.168.122.255 scope global virbr0
      valid_lft forever preferred_lft forever
      7: virbr0-nic: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast master virbr0 state DOWN qlen 500
      link/ether 52:54:00:99:14:38 brd ff:ff:ff:ff:ff:ff
      8: cloud0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN
      link/ether 72:0f:e1:35:ac:6b brd ff:ff:ff:ff:ff:ff
      inet 169.254.0.1/16 scope global cloud0
      valid_lft forever preferred_lft forever
      inet6 fe80::700f:e1ff:fe35:ac6b/64 scope link
      valid_lft forever preferred_lft forever
      [root@acs ~]#

      workaround:

      Don't use ensX format.

      add net.ifnames=0 biosdevname=0 to GRUB_CMDLINE_LINUX

      [root@acs ~]# vi /etc/default/grub
      :
      GRUB_CMDLINE_LINUX="vconsole.keymap=jp106 crashkernel=auto vconsole.font=latarcyrheb-sun16 rhgb quiet net.ifnames=0 biosdevname=0"
      :
      [root@acs ~]# grub2-mkconfig -o /boot/grub2/grub.cfg

      And
      Edit /etc/sysconfig/network-scripts/ifcfg-ensX

      ensX-> ethX

      [root@acs ~]# reboot

      :

      [root@acs ~]# ip a
      1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN
      link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
      inet 127.0.0.1/8 scope host lo
      valid_lft forever preferred_lft forever
      inet6 ::1/128 scope host
      valid_lft forever preferred_lft forever
      2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master cloudbr0 state UP qlen 1000
      link/ether 00:0c:29:a9:09:3f brd ff:ff:ff:ff:ff:ff
      inet6 fe80::20c:29ff:fea9:93f/64 scope link
      valid_lft forever preferred_lft forever
      3: eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast master cloudbr1 state UP qlen 1000
      link/ether 00:0c:29:a9:09:49 brd ff:ff:ff:ff:ff:ff
      inet6 fe80::20c:29ff:fea9:949/64 scope link
      valid_lft forever preferred_lft forever
      4: cloudbr0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP
      link/ether 00:0c:29:a9:09:3f brd ff:ff:ff:ff:ff:ff
      inet 10.0.0.30/24 brd 10.0.0.255 scope global cloudbr0
      valid_lft forever preferred_lft forever
      inet6 fe80::20c:29ff:fea9:93f/64 scope link
      valid_lft forever preferred_lft forever
      5: cloudbr1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP
      link/ether 00:0c:29:a9:09:49 brd ff:ff:ff:ff:ff:ff
      inet6 fe80::20c:29ff:fea9:949/64 scope link
      valid_lft forever preferred_lft forever
      6: virbr0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN
      link/ether 52:54:00:99:14:38 brd ff:ff:ff:ff:ff:ff
      inet 192.168.122.1/24 brd 192.168.122.255 scope global virbr0
      valid_lft forever preferred_lft forever
      7: virbr0-nic: <BROADCAST,MULTICAST> mtu 1500 qdisc pfifo_fast master virbr0 state DOWN qlen 500
      link/ether 52:54:00:99:14:38 brd ff:ff:ff:ff:ff:ff
      8: cloud0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UNKNOWN
      link/ether 26:08:0e:aa:44:f7 brd ff:ff:ff:ff:ff:ff
      inet 169.254.0.1/16 scope global cloud0
      valid_lft forever preferred_lft forever
      inet6 fe80::2408:eff:feaa:44f7/64 scope link
      valid_lft forever preferred_lft forever
      [root@acs ~]#

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user giraffeforestg opened a pull request:

          https://github.com/apache/cloudstack/pull/811

          fix CLOUDSTACK-8838

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/giraffeforestg/cloudstack fix_CLOUDSTACK-8838

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cloudstack/pull/811.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #811


          commit 49bd458bf931121ccbda3b4feb4fd023975df831
          Author: Satoru Nakaya <giraffeforestg@gmail.com>
          Date: 2015-09-12T11:38:54Z

          fix CLOUDSTACK-8838


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user giraffeforestg opened a pull request: https://github.com/apache/cloudstack/pull/811 fix CLOUDSTACK-8838 You can merge this pull request into a Git repository by running: $ git pull https://github.com/giraffeforestg/cloudstack fix_ CLOUDSTACK-8838 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/811.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #811 commit 49bd458bf931121ccbda3b4feb4fd023975df831 Author: Satoru Nakaya <giraffeforestg@gmail.com> Date: 2015-09-12T11:38:54Z fix CLOUDSTACK-8838
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/811#issuecomment-139783503

          @giraffeforestg can you please add a bit more descriptive title?

          Something like:
          CLOUDSTACK-8838: Allow ensX format for nics in CentOS 7

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139783503 @giraffeforestg can you please add a bit more descriptive title? Something like: CLOUDSTACK-8838 : Allow ensX format for nics in CentOS 7
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user giraffeforestg commented on the pull request:

          https://github.com/apache/cloudstack/pull/811#issuecomment-139825175

          Hi.
          Thank you for your advice.
          I corrected the title.

          Show
          githubbot ASF GitHub Bot added a comment - Github user giraffeforestg commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139825175 Hi. Thank you for your advice. I corrected the title.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/811#issuecomment-139854597

          @giraffeforestg Thanks. Is it an idea to add all possible systemd names to prevent more issues in the future?

          ```
          With systemd 197 we have added native support for a number of different naming policies into systemd/udevd proper and made a scheme similar to biosdevname's (but generally more powerful, and closer to kernel-internal device identification schemes) the default. The following different naming schemes for network interfaces are now supported by udev natively:

          Names incorporating Firmware/BIOS provided index numbers for on-board devices (example: eno1)
          Names incorporating Firmware/BIOS provided PCI Express hotplug slot index numbers (example: ens1)
          Names incorporating physical/geographical location of the connector of the hardware (example: enp2s0)
          Names incorporating the interfaces's MAC address (example: enx78e7d1ea46da)
          Classic, unpredictable kernel-native ethX naming (example: eth0)
          ```
          Source: http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/

          Shall we add: enoX enpX enxX as well?

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139854597 @giraffeforestg Thanks. Is it an idea to add all possible systemd names to prevent more issues in the future? ``` With systemd 197 we have added native support for a number of different naming policies into systemd/udevd proper and made a scheme similar to biosdevname's (but generally more powerful, and closer to kernel-internal device identification schemes) the default. The following different naming schemes for network interfaces are now supported by udev natively: Names incorporating Firmware/BIOS provided index numbers for on-board devices (example: eno1) Names incorporating Firmware/BIOS provided PCI Express hotplug slot index numbers (example: ens1) Names incorporating physical/geographical location of the connector of the hardware (example: enp2s0) Names incorporating the interfaces's MAC address (example: enx78e7d1ea46da) Classic, unpredictable kernel-native ethX naming (example: eth0) ``` Source: http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/ Shall we add: enoX enpX enxX as well?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user giraffeforestg commented on the pull request:

          https://github.com/apache/cloudstack/pull/811#issuecomment-139868712

          OK.
          I will modify the code.

          Show
          githubbot ASF GitHub Bot added a comment - Github user giraffeforestg commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139868712 OK. I will modify the code.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user giraffeforestg closed the pull request at:

          https://github.com/apache/cloudstack/pull/811

          Show
          githubbot ASF GitHub Bot added a comment - Github user giraffeforestg closed the pull request at: https://github.com/apache/cloudstack/pull/811
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/811#issuecomment-139869756

          @giraffeforestg Awesom! You may also leave the PR open and push more commits once done. Whatever suits you

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139869756 @giraffeforestg Awesom! You may also leave the PR open and push more commits once done. Whatever suits you
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user giraffeforestg opened a pull request:

          https://github.com/apache/cloudstack/pull/812

          CLOUDSTACK-8838: Allow ensX enoX enpX enxX format for nics in CentOS 7

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/giraffeforestg/cloudstack CLOUDSTACK-8838

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cloudstack/pull/812.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #812


          commit e8c5ed4e3de8129895feb648066f0c29f49da63d
          Author: Satoru Nakaya <giraffeforestg@gmail.com>
          Date: 2015-09-13T13:13:30Z

          CLOUDSTACK-8838: Allow ensX enoX enpX enxX format for nics in CentOS 7


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user giraffeforestg opened a pull request: https://github.com/apache/cloudstack/pull/812 CLOUDSTACK-8838 : Allow ensX enoX enpX enxX format for nics in CentOS 7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/giraffeforestg/cloudstack CLOUDSTACK-8838 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/812.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #812 commit e8c5ed4e3de8129895feb648066f0c29f49da63d Author: Satoru Nakaya <giraffeforestg@gmail.com> Date: 2015-09-13T13:13:30Z CLOUDSTACK-8838 : Allow ensX enoX enpX enxX format for nics in CentOS 7
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user giraffeforestg commented on the pull request:

          https://github.com/apache/cloudstack/pull/811#issuecomment-139873507

          sorry.
          I am not familiar.
          https://github.com/apache/cloudstack/pull/812

          Show
          githubbot ASF GitHub Bot added a comment - Github user giraffeforestg commented on the pull request: https://github.com/apache/cloudstack/pull/811#issuecomment-139873507 sorry. I am not familiar. https://github.com/apache/cloudstack/pull/812
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/812#issuecomment-139874783

          @giraffeforestg Thanks for picking this up! Will test it tomorrow.

          FYI: You can always make changes after the PR is opened. If you'd want to change something now, you'd push a new commit to `giraffeforestg:CLOUDSTACK-8838`. You can also alter an existing commit, or overwrite it using `-f` when pushing. In other words, whatever you do to your branch `giraffeforestg:CLOUDSTACK-8838` that this PR is linked to, will end up here.
          Don't get me wrong, opening a new PR is just fine too

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-139874783 @giraffeforestg Thanks for picking this up! Will test it tomorrow. FYI: You can always make changes after the PR is opened. If you'd want to change something now, you'd push a new commit to `giraffeforestg: CLOUDSTACK-8838 `. You can also alter an existing commit, or overwrite it using `-f` when pushing. In other words, whatever you do to your branch `giraffeforestg: CLOUDSTACK-8838 ` that this PR is linked to, will end up here. Don't get me wrong, opening a new PR is just fine too
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user wido commented on the pull request:

          https://github.com/apache/cloudstack/pull/812#issuecomment-139914467

          Looking at the if-statement I give it a LGTM

          Show
          githubbot ASF GitHub Bot added a comment - Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-139914467 Looking at the if-statement I give it a LGTM
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user rafaelweingartner commented on the pull request:

          https://github.com/apache/cloudstack/pull/812#issuecomment-139914691

          Why don’t you extract the content of line 1164 (the condition) to a method, this way it is possible to create a test case and enables some java doc. Moreover, the code becomes easier to read.

          Show
          githubbot ASF GitHub Bot added a comment - Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-139914691 Why don’t you extract the content of line 1164 (the condition) to a method, this way it is possible to create a test case and enables some java doc. Moreover, the code becomes easier to read.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bhaisaab commented on the pull request:

          https://github.com/apache/cloudstack/pull/812#issuecomment-140650851

          LGTM, given the if conditions

          Show
          githubbot ASF GitHub Bot added a comment - Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-140650851 LGTM, given the if conditions
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user DaanHoogland commented on the pull request:

          https://github.com/apache/cloudstack/pull/812#issuecomment-140658229

          I agree with @rafaelweingartner that this can have (and deserves) a unit test maybe it can even be generalized to dynamically find nic prefixes or at least have a list of them ourside the condition. It will make the code clearer and thus better maintainable

          Show
          githubbot ASF GitHub Bot added a comment - Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-140658229 I agree with @rafaelweingartner that this can have (and deserves) a unit test maybe it can even be generalized to dynamically find nic prefixes or at least have a list of them ourside the condition. It will make the code clearer and thus better maintainable
          Hide
          remibergsma Remi Bergsma added a comment -

          Also for 'team' devices as per PR 966.

          Show
          remibergsma Remi Bergsma added a comment - Also for 'team' devices as per PR 966.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/973#issuecomment-150783732

          @DaanHoogland Can you prepend the title with CLOUDSTACK-8838 please? I put a note on the original ticket that it was solved in a more generic way.

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150783732 @DaanHoogland Can you prepend the title with CLOUDSTACK-8838 please? I put a note on the original ticket that it was solved in a more generic way.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user DaanHoogland commented on the pull request:

          https://github.com/apache/cloudstack/pull/973#issuecomment-150783777

          @remibergsma title prefix added to the PR, would you wnat it on the commit as well?

          Show
          githubbot ASF GitHub Bot added a comment - Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150783777 @remibergsma title prefix added to the PR, would you wnat it on the commit as well?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user remibergsma commented on the pull request:

          https://github.com/apache/cloudstack/pull/973#issuecomment-150785113

          @DaanHoogland No, just the PR title. Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150785113 @DaanHoogland No, just the PR title. Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user borisroman commented on the pull request:

          https://github.com/apache/cloudstack/pull/973#issuecomment-150953447

          @remibergsma @DaanHoogland LGTM :+1:

          Thanks for adjusting the unit test.

          ```
          Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
          Tests run: 143, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.916 sec - in com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
          ```

          Show
          githubbot ASF GitHub Bot added a comment - Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/973#issuecomment-150953447 @remibergsma @DaanHoogland LGTM :+1: Thanks for adjusting the unit test. ``` Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest Tests run: 143, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.916 sec - in com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest ```
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b69dff7905a1fc7a39ae951eb3fb63ac65c35bf5 in cloudstack's branch refs/heads/master from Remi Bergsma
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b69dff7 ]

          Merge pull request #973 from DaanHoogland/interfacePatternCheck

          CLOUDSTACK-8838 Interface pattern checkthsi closes #812 and #966 as well

          • pr/973:
            unit test for interface patterns in libvirt compute resource
            Added support for KVM teamd devices to LibvirtComputingResource.java. This will allow users to utilze teamd nic teaming devices named team*.
            CLOUDSTACK-8838: Allow ensX enoX enpX enxX format for nics in CentOS 7

          Signed-off-by: Remi Bergsma <github@remi.nl>

          Show
          jira-bot ASF subversion and git services added a comment - Commit b69dff7905a1fc7a39ae951eb3fb63ac65c35bf5 in cloudstack's branch refs/heads/master from Remi Bergsma [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b69dff7 ] Merge pull request #973 from DaanHoogland/interfacePatternCheck CLOUDSTACK-8838 Interface pattern checkthsi closes #812 and #966 as well pr/973: unit test for interface patterns in libvirt compute resource Added support for KVM teamd devices to LibvirtComputingResource.java. This will allow users to utilze teamd nic teaming devices named team*. CLOUDSTACK-8838 : Allow ensX enoX enpX enxX format for nics in CentOS 7 Signed-off-by: Remi Bergsma <github@remi.nl>
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b69dff7905a1fc7a39ae951eb3fb63ac65c35bf5 in cloudstack's branch refs/heads/master from Remi Bergsma
          [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b69dff7 ]

          Merge pull request #973 from DaanHoogland/interfacePatternCheck

          CLOUDSTACK-8838 Interface pattern checkthsi closes #812 and #966 as well

          • pr/973:
            unit test for interface patterns in libvirt compute resource
            Added support for KVM teamd devices to LibvirtComputingResource.java. This will allow users to utilze teamd nic teaming devices named team*.
            CLOUDSTACK-8838: Allow ensX enoX enpX enxX format for nics in CentOS 7

          Signed-off-by: Remi Bergsma <github@remi.nl>

          Show
          jira-bot ASF subversion and git services added a comment - Commit b69dff7905a1fc7a39ae951eb3fb63ac65c35bf5 in cloudstack's branch refs/heads/master from Remi Bergsma [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b69dff7 ] Merge pull request #973 from DaanHoogland/interfacePatternCheck CLOUDSTACK-8838 Interface pattern checkthsi closes #812 and #966 as well pr/973: unit test for interface patterns in libvirt compute resource Added support for KVM teamd devices to LibvirtComputingResource.java. This will allow users to utilze teamd nic teaming devices named team*. CLOUDSTACK-8838 : Allow ensX enoX enpX enxX format for nics in CentOS 7 Signed-off-by: Remi Bergsma <github@remi.nl>
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cloudstack/pull/812

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/812
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cloudstack/pull/973

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/973
          Hide
          remibergsma Remi Bergsma added a comment -

          merged!

          Show
          remibergsma Remi Bergsma added a comment - merged!

            People

            • Assignee:
              dahn Daan Hoogland
              Reporter:
              giraffeforestg satoru nakaya
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development