[CLOUDSTACK-8551] Findbugs warning in LdapCreateAccountCmd.java and LdapImportUsersCmd.java

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.3.0, 4.4.0, 4.5.1
• Fix Version/s: 4.6.0
• Security Level: Public (Anyone can view this level - this is the default.)
• Labels: ldap
• Assignee: Rajani Karuturi
• Reporter: Rajani Karuturi
• Created: 11/Jun/15 07:03
• Updated: 27/Jul/15 12:01
• Resolved: 27/Jul/15 12:01

Description

LdapCreateAccountCmd.java:146, DMI_INVOKING_TOSTRING_ON_ARRAY, Priority: High

Invocation of toString on org.bouncycastle.util.encoders.Base64.encode(byte[]) in org.apache.cloudstack.api.command.LdapCreateAccountCmd.generatePassword()

The code invokes toString on an array, which will generate a fairly useless result such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12.

LdapImportUsersCmd.java:231, DM_DEFAULT_ENCODING, Priority: High

Found reliance on default encoding in org.apache.cloudstack.api.command.LdapImportUsersCmd.generatePassword(): new String(byte[])

Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly.