[CLOUDSTACK-4176] [XenServer] Nic not unplugged after all IPs are released

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.2.0
• Fix Version/s: 4.2.0
• Component/s: XenServer
• Security Level: Public (Anyone can view this level - this is the default.)
• Labels: integration-test
• Assignee: Jayapal
• Reporter: Kishan
• Created: 08/Aug/13 06:37
• Updated: 19/Aug/13 18:15
• Resolved: 19/Aug/13 18:15

Description

Nic should be unplugged after all the public IPs assigned to it are released. Currently nics are not being reused due to this bug.

Code to set removeVif was removed
else if (!add && firstIP)

{ /* FIXME: This is incorrect. Because you can only tell if it's the first IP in this bundle of ip address which send to the router, * but don't know if it's the only IP left in the router - because we didn't send all the related vlan's IPs to the router now. */ removeVif = true; }