CloudStack
  1. CloudStack
  2. CLOUDSTACK-196

cloud-set-guest-password enhancement to support Debian (and derivatives)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: pre-4.0.0
    • Fix Version/s: pre-4.0.0
    • Component/s: Template
    • Security Level: Public (Anyone can view this level - this is the default.)
    • Labels:

      Description

      The passwd utility on Debian based distributions does not support the --stdin option. I propose updating the script located at http://cloudstack.org/dl/cloud-set-guest-password to use the chpasswd utility instead.

      Additionally, Ubuntu 12.04 places DHCP lease information in /etc/dhcp/*. I propose adding this to the search patch used when looking for the DHCP server.

      Patch attached

        Activity

        Matty Courtney created issue -
        Matty Courtney made changes -
        Field Original Value New Value
        Attachment cloud-set-guest-password.patch [ 12546426 ]
        Matty Courtney made changes -
        Description The passwd utility on Debian based distributions does not support the --stdin option. I propose updating the script located at http://cloudstack.org/dl/cloud-set-guest-password to use the chpasswd utility instead.

        Additionally, Ubuntu 12.04 places DHCP lease information in /etc/dhcp/*. I propose adding this to the search patch used when looking for the DHCP server.
        The passwd utility on Debian based distributions does not support the --stdin option. I propose updating the script located at http://cloudstack.org/dl/cloud-set-guest-password to use the chpasswd utility instead.

        Additionally, Ubuntu 12.04 places DHCP lease information in /etc/dhcp/*. I propose adding this to the search patch used when looking for the DHCP server.

        Patch attached
        Hide
        edison su added a comment -

        Thanks for your patch. Could you help to send the patch to https://reviews.apache.org/r/new/, repository selects "cloudstack". Apache review board is the formal place for people reviewing code. Note: need to register an account in review board though.

        Show
        edison su added a comment - Thanks for your patch. Could you help to send the patch to https://reviews.apache.org/r/new/ , repository selects "cloudstack". Apache review board is the formal place for people reviewing code. Note: need to register an account in review board though.
        Hide
        edison su added a comment -

        If you have cloudstack source code, you can find cloud-set-guest-password at tools/guest_password/cloud-set-guest-password on cloudstack master branch(https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git). Better to send a patch against this repo.

        Show
        edison su added a comment - If you have cloudstack source code, you can find cloud-set-guest-password at tools/guest_password/cloud-set-guest-password on cloudstack master branch( https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git ). Better to send a patch against this repo.
        Hide
        Matty Courtney added a comment -

        Thanks for the feedback! I've submitted a review request as #7243.

        Show
        Matty Courtney added a comment - Thanks for the feedback! I've submitted a review request as #7243.
        Sudha Ponnaganti made changes -
        Fix Version/s pre-4.0.0 [ 12323252 ]
        Affects Version/s pre-4.0.0 [ 12323252 ]
        Hide
        Sudha Ponnaganti added a comment -

        Matty,

        I couldn't assign this to you as you are not whoing up in assignee list. Can you resolve it once review request is closed on review board

        thanks
        /sudha

        Show
        Sudha Ponnaganti added a comment - Matty, I couldn't assign this to you as you are not whoing up in assignee list. Can you resolve it once review request is closed on review board thanks /sudha
        Hide
        edison su added a comment -

        fixed in 062e94a317130bf5478b96e04689addbbe473df2, but need to fire another bug, to update the download url.

        Show
        edison su added a comment - fixed in 062e94a317130bf5478b96e04689addbbe473df2, but need to fire another bug, to update the download url.
        edison su made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        21h 9m 1 edison su 25/Sep/12 23:44

          People

          • Assignee:
            Unassigned
            Reporter:
            Matty Courtney
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development