[CLOUDSTACK-1638] Network plugins won't be notified VM migration.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0
• Fix Version/s: 4.2.0
• Component/s: Management Server
• Security Level: Public (Anyone can view this level - this is the default.)
• Labels: patch
• Assignee: Hiroaki Kawai
• Reporter: Hiroaki Kawai
• Created: 12/Mar/13 07:18
• Updated: 22/Jul/13 05:37
• Resolved: 20/May/13 23:45

Description

The location of the virtual machine is provided by DeployDestination, which will be passed in NetworkGuru#reserve and NetworkElement#prepare.

During the virtual machine migration, it actually changes DeployDestination and it looks like that it will tell that event to network components as it has NetworkManager#prepareNicForMigration. The problem is that althogh the interface has that method, NetworkManagerImpl does not tell the DeployDestination changes to network components.

So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And then, we also need to add calls NetworkGuru#release and NetworkElement#release after the migration, otherwise the network resources that plugin reserved will be kept even when the vm leaves off.