Click
  1. Click
  2. CLK-743

Deprecate TreeNode constructor which accepts parent node

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0-M1
    • Fix Version/s: 2.3.0-RC1
    • Component/s: extras
    • Labels:
      None

      Description

      TreeNode has constructors that accepts a parent node to which the new node is added to. This leads to the following code:

      new TrreNode("node1", parent);

      a little confusing because the newly created node isn't assigned and looks unused.

      By using one of the alternative consturctors we get this:

      TreeNode child = new TrreNode("node1");
      parent.add(child);

      Now the code is clear as to what is happening.

        Activity

        Bob Schellink made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Bob Schellink made changes -
        Field Original Value New Value
        Summary Deprecate TrreNode constructor which accepts parent node Deprecate TreeNode constructor which accepts parent node
        Bob Schellink created issue -

          People

          • Assignee:
            Bob Schellink
            Reporter:
            Bob Schellink
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development