Click
  1. Click
  2. CLK-717

Click 2.2 DTD does not allow a custom Format class

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.3.0-M1
    • Component/s: core
    • Labels:
      None
    • Environment:
      Java 1.6, Jetty, Mac OS X

      Description

      The DTD for Click 2.2 has a fixed value for the format classname. This results in an XML validation error when attempting to specify a custom Format class.

      <!-- Page template formatter class. An new format object added to
      the Velocity context under the key: "format". -->
      <!ELEMENT format (#PCDATA)>
      <!ATTLIST format classname CDATA #FIXED "org.apache.click.util.Format">

        Activity

        Hide
        Bob Schellink added a comment -

        I don't know much about DTD's, but can we remove the #FIXED attribe from the various elements? Is there another reason for it?

        Show
        Bob Schellink added a comment - I don't know much about DTD's, but can we remove the #FIXED attribe from the various elements? Is there another reason for it?
        Hide
        Ryan Holmes added a comment -

        I'm not a DTD expert either, but according to the ATTLIST tutorial at http://www.w3schools.com/dtd/dtd_attributes.asp, yes, #FIXED can simply be removed and "org.apache.click.util.Format" will be the default value.

        Show
        Ryan Holmes added a comment - I'm not a DTD expert either, but according to the ATTLIST tutorial at http://www.w3schools.com/dtd/dtd_attributes.asp , yes, #FIXED can simply be removed and "org.apache.click.util.Format" will be the default value.
        Hide
        Bob Schellink added a comment -

        Fixed in trunk. Needs to be updated on the website though.

        Show
        Bob Schellink added a comment - Fixed in trunk. Needs to be updated on the website though.
        Hide
        Bob Schellink added a comment -

        Fixed in trunk and updated website. Should be live in an hour or so

        Show
        Bob Schellink added a comment - Fixed in trunk and updated website. Should be live in an hour or so

          People

          • Assignee:
            Bob Schellink
            Reporter:
            Ryan Holmes
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development