[CLK-601] TextField sets size when not appropriate

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.1.0 RC1
• Fix Version/s: 3.0.0
• Component/s: core
• Assignee: Adrian A.
• Reporter: WarnerJan Veldhuis
• Created: 30/Dec/09 13:31
• Updated: 02/Nov/13 22:49
• Resolved: 02/Nov/13 22:49

Description

In the TextField class, the size attribute is always rendered regardless of the value of size. Since the size-attribute should be optional for the input-tag, it should be conditional, just as it is the case with maxLength and tabIndex. This would also mean that the default of 20 should be dropped.

current code:
buffer.appendAttribute("size", getSize());

proposed code:
if ( getSize() > 0 ) {
buffer.appendAttribute("size", getSize());
}

Since the HTML-spec says size is implied, it should only be added if there is any size.