Click
  1. Click
  2. CLK-535

Link control to be able to render both icon an text

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0
    • Component/s: core
    • Labels:
      None

      Description

      Link control should be able to render both the icon (if existing), and text too:
      http://thread.gmane.org/gmane.comp.web.click.user/3017

      1. Link_renderBoth.diff
        4 kB
        Adrian A.
      2. LinkDemo_update.diff
        3 kB
        Adrian A.

        Activity

        Hide
        Adrian A. added a comment -

        > don't think calling the property renderBoth is too user friendly though. How about renderLabelAndImage?
        Changed to 'renderLabelAndImage'.

        > We should also update the javadoc for setImageSrc and getImageSrc about the new option for
        > rendering both text and images.
        Done.

        > Its also worth updating the Changes & Roadmap html to communicate this fix to users.
        Done.

        Show
        Adrian A. added a comment - > don't think calling the property renderBoth is too user friendly though. How about renderLabelAndImage? Changed to 'renderLabelAndImage'. > We should also update the javadoc for setImageSrc and getImageSrc about the new option for > rendering both text and images. Done. > Its also worth updating the Changes & Roadmap html to communicate this fix to users. Done.
        Hide
        Bob Schellink added a comment -

        Thanks for fixing this Adrian.

        I don't think calling the property renderBoth is too user friendly though. How about renderLabelAndImage? We should also update the javadoc for setImageSrc and getImageSrc about the new option for rendering both text and images.

        Its also worth updating the Changes & Roadmap html to communicate this fix to users.

        Show
        Bob Schellink added a comment - Thanks for fixing this Adrian. I don't think calling the property renderBoth is too user friendly though. How about renderLabelAndImage? We should also update the javadoc for setImageSrc and getImageSrc about the new option for rendering both text and images. Its also worth updating the Changes & Roadmap html to communicate this fix to users.
        Hide
        Adrian A. added a comment -

        Long standing patches were checked in.

        Show
        Adrian A. added a comment - Long standing patches were checked in.
        Hide
        Adrian A. added a comment -

        This patch (LinkDemo_update.diff) improves the LinkDemo page with more link example usage (as well as the new possibility to render both icon and label for a link)

        Show
        Adrian A. added a comment - This patch (LinkDemo_update.diff) improves the LinkDemo page with more link example usage (as well as the new possibility to render both icon and label for a link)
        Hide
        Adrian A. added a comment -

        This patch (Link_renderBoth.diff) allows to render both icon and label for a link.

        Show
        Adrian A. added a comment - This patch (Link_renderBoth.diff) allows to render both icon and label for a link.

          People

          • Assignee:
            Adrian A.
            Reporter:
            Adrian A.
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development