Uploaded image for project: 'Click'
  1. Click
  2. CLK-306

Replacing OGNL with MVEL

    XMLWordPrintableJSON

Details

    • New Feature
    • Status: In Progress
    • Major
    • Resolution: Unresolved
    • 1.4
    • 2.4.0-RC1
    • core
    • None
    • Target Click 1.5

    Description

      I have been following both OGNL and MVEL (another expression language) development the last couple of months. If we are going to make changes to this here are some things you might find interesting:

      • OGNL 2.7.1 which is included in tapestry 4.1, now sports byte code enhancement. This was added by one of the tapestry authors to make OGNL much faster than its reflection mode. However in my testing 2.7.1 threw exceptions every now and then. So still buggy.
      • MVEL (http://mvel.codehaus.org/) seems like a good replacement for OGNL. It has good docs and is actively developed. They even fixed a bug I logged! Like OGNL, MVEL also runs in two modes, either reflection or byte compiled. Unlike OGNL, MVEL's reflection mode is faster than Click's reflection mode.

      I am no expert on this but according to the article below (from MVEL's author), byte code enhancement have some problems in that generated classes accumulate in java's perm space and will only be removed when their classloader is removed.
      http://artexpressive.blogspot.com/2007/07/mvel-by-numbers-real-story.html

      So MVEL in reflection mode looks like an ideal solution here. The power of OGNL with the performance of Click reflection.

      Table columns can again take advantage of expressions. For example to aggregate a total for the row -> new Column("price * tax");

      Attachments

        1. ASF.LICENSE.NOT.GRANTED--expression-language-performance.rar
          5 kB
          Bob Schellink
        2. ASF.LICENSE.NOT.GRANTED--expression-language-performance.zip
          5 kB
          Bob Schellink
        3. mvel.zip
          1 kB
          Gilberto C Andrade
        4. patch.diff
          2 kB
          Gilberto C Andrade

        Activity

          People

            medgar Malcolm Edgar
            sabob Bob Schellink
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: