[CLK-305] Table control might allocate excessive memory

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: core
• Environment: Click 1.3.1 / 1.4RC2
• Assignee: Malcolm Edgar
• Reporter: Naoki Takezoe
• Created: 04/Feb/08 09:10
• Updated: 11/Feb/08 03:45
• Resolved: 05/Feb/08 02:40

Description

Table#toString() allocate memory for HtmlStringBuffer.

int bufferSize =
(getColumnList().size() * 60) * (getRowList().size() + 1);

However, when Table is paginated, Table control allocates excessive memory.
I think if the page size is specified, the initial buffer size should be calculated by the page size:

int bufferSize =
(getColumnList().size() * 60) * (getPageSize() + 1);
^^^^^^^^^^^^^

I'm using Table with large rows. So sometimes, it causes OutOfMemory by this issue.