[CLK-303] Menu does not encodeURL

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: extras
• Environment: Click 1.4RC2
• Assignee: Bob Schellink
• Reporter: Bob Schellink
• Created: 31/Jan/08 11:27
• Updated: 11/Feb/08 04:56
• Resolved: 01/Feb/08 11:03

Description

Need to update getHref from this:

public String getHref() {
if (isExternal() || "#".equals(getPath()))

{ return getPath(); } else { return getContext().getRequest().getContextPath() + "/" + getPath(); }
}

to this:

public String getHref() {
if (isExternal()) { return getPath(); }

else if ("#".equals(getPath()))

{ return getContext().getResponse().encodeURL(getPath()); }

else

{ return getContext().getResponse().encodeURL(getContext().getRequest().getContextPath() + "/" + getPath()); }

}

I am not 100% sure if we should call encodeURL if path equals '#'.