Uploaded image for project: 'Click'
  1. Click
  2. CLK-268

Tables Shouldn't Clear RowList in onDestroy()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      Doing so prevents the Table from functioning correctly on a Stateful page. Also, if the list is unmodifiable an exception is thrown. Why isn't the lifetime of the rowList the same as the table?

        Activity

        Hide
        medgar Malcolm Edgar added a comment -

        Hi Joel,

        the concept here was that the Table rowList could be very large, and we didn't want it being serialized, as it could really blow out the size of the session on the server.

        However, it is possible that we should think of making this behaviour configurable, with a table property "clearRowListOnDestroy", or we could just set the rowList instance variable to null.

        regards Malcolm Edgar

        Show
        medgar Malcolm Edgar added a comment - Hi Joel, the concept here was that the Table rowList could be very large, and we didn't want it being serialized, as it could really blow out the size of the session on the server. However, it is possible that we should think of making this behaviour configurable, with a table property "clearRowListOnDestroy", or we could just set the rowList instance variable to null. regards Malcolm Edgar
        Hide
        medgar Malcolm Edgar added a comment -

        Added clearRowListOnDestroy property. Will be available in release 1.4RC2.

        regards Malcolm Edgar

        Show
        medgar Malcolm Edgar added a comment - Added clearRowListOnDestroy property. Will be available in release 1.4RC2. regards Malcolm Edgar

          People

          • Assignee:
            medgar Malcolm Edgar
            Reporter:
            jas Joel Schmidt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development