Click
  1. Click
  2. CLK-241

Table Headers use incorrect title attribute (table-last-title) when sortable=true

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0-M1
    • Component/s: core
    • Labels:
      None
    • Environment:
      Click 1.4RC1

      Description

      In the renderTableHeader() method of the Column class, the actionLink is retrieved from getTable().getControlLink().
      This method sends back the ActionLink used for paging, but...

      The problem is that the title of this ActionLinks is already set to getMessage("table-last-title") in the renderPagingControls() method of the Table class if the banner position is TOP or BOTH, and it is not set again in the renderTableHeader() method.

      Proposed solution : at least set the title of the retrieved ActionLink to somehting meaningful in the renderTableHeader() method, like controlLink.setAttribute("title", getMessage("table-sort-links")), where the entry would resolve to "Sort by" in the click-control.properties file ("Trié par" in French).

      Easy to fix for the 1.4 release, I think.

        Activity

        No work has yet been logged on this issue.

          People

          • Assignee:
            Bob Schellink
            Reporter:
            Patrick Talbot
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development