Click
  1. Click
  2. CLK-179

FileField configurations does not be applied

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      I know that this issue is explained in Javadoc - Context#getRequestParameter().
      Actually, irrelevant Controls to Form interfere in the processing of
      the multipart data.

      I want to expand the chance that FileField configurations is applied.
      Especially, when it wants to limit the data size by using the function of
      Commons FileUpload, I feel the necessity.

      ActionLink and ActionButton are sure to function only by HTTP GET Method
      if my understanding is correct.

      The attached patch is the one to fix to check whether the request is
      a Content-type "multipart/form-data" POST request, before
      Context#getRequestParameter is called in Action(Link|Button)#onProcess.

        Activity

        Sadanori Ito created issue -
        Sadanori Ito made changes -
        Field Original Value New Value
        Attachment filefield-config-patch.txt [ 10225 ]
        Hide
        Malcolm Edgar added a comment -

        Hi Sadanori,

        I am not sure why this check would be necessary? Have you had a scenario where this was required?

        regards Malcolm Edgar

        Show
        Malcolm Edgar added a comment - Hi Sadanori, I am not sure why this check would be necessary? Have you had a scenario where this was required? regards Malcolm Edgar
        Malcolm Edgar made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Sadanori Ito added a comment -

        I attached minimum webapp code to reproduce this issue.

        Previous patch is a minimum correction, and I think that
        it should essentially reexamine the order of evaluating the request.
        However, changes for processing the request is very sensitive issue.

        Show
        Sadanori Ito added a comment - I attached minimum webapp code to reproduce this issue. Previous patch is a minimum correction, and I think that it should essentially reexamine the order of evaluating the request. However, changes for processing the request is very sensitive issue.
        Sadanori Ito made changes -
        Attachment clk-179.zip [ 10228 ]
        Hide
        Malcolm Edgar added a comment -

        Fix checked in, will be available in release 1.3

        Show
        Malcolm Edgar added a comment - Fix checked in, will be available in release 1.3
        Malcolm Edgar made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Malcolm Edgar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Henri Yandell made changes -
        Project Import Fri Mar 20 14:11:32 PDT 2009 [ 1237583492744 ]

          People

          • Assignee:
            Malcolm Edgar
            Reporter:
            Sadanori Ito
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development