Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      Hi

      The parameter order in the constructors of the Radio control are not consistent with the other controls. The order of the parameters are usually name, label, value but Radio is value, label, name.

      Ill attach a patch. This patch will break all existing Radio usage so might not be worth applying to Click.

      regards

      bob

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3h 4m 1 Malcolm Edgar 24/Nov/06 16:44
        Resolved Resolved Closed Closed
        122d 5h 4m 1 Malcolm Edgar 26/Mar/07 22:49
        Henri Yandell made changes -
        Project Import Fri Mar 20 14:11:32 PDT 2009 [ 1237583492744 ]
        Malcolm Edgar made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Malcolm Edgar made changes -
        Resolution Won't Fix [ 2 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Malcolm Edgar added a comment -

        Hi Bob,

        the radio constructor is a bit different from other fields, because its name is often derived from a parent RadioGroup, and its use case is more like a Select Option value. The motivation here is to make the easiest to use constructor, ie only one parameter.

        I agree with your point that changing the constructor would break existing code, so I would not want to apply this patch.

        Thanks the the consideration however.

        regards Malcolm Edgar

        Show
        Malcolm Edgar added a comment - Hi Bob, the radio constructor is a bit different from other fields, because its name is often derived from a parent RadioGroup, and its use case is more like a Select Option value. The motivation here is to make the easiest to use constructor, ie only one parameter. I agree with your point that changing the constructor would break existing code, so I would not want to apply this patch. Thanks the the consideration however. regards Malcolm Edgar
        Bob Schellink made changes -
        Field Original Value New Value
        Attachment Radio.patch [ 10158 ]
        Bob Schellink created issue -

          People

          • Assignee:
            Malcolm Edgar
            Reporter:
            Bob Schellink
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development