Uploaded image for project: 'Apache Open Climate Workbench'
  1. Apache Open Climate Workbench
  2. CLIMATE-897

Make sure shapes of numpy arrays contain only integer values

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Labels:
      None

      Description

      For python 3, floor division is done with a new operator (//). And newer versions of numpy require all shape values to be integers. This leads to errors when running ocw with python 3 in a few places since some shapes are generated using the old division operator which generates a float in python 3. See: https://travis-ci.org/agoodm/climate/jobs/204421839

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user agoodm opened a pull request:

          https://github.com/apache/climate/pull/427

          CLIMATE-897 Make sure shapes of numpy arrays contain only integer values

          Should fix the errors shown in travis CI for python 3:

          https://travis-ci.org/agoodm/climate/jobs/204421839

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/agoodm/climate CLIMATE-897

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/climate/pull/427.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #427



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user agoodm opened a pull request: https://github.com/apache/climate/pull/427 CLIMATE-897 Make sure shapes of numpy arrays contain only integer values Should fix the errors shown in travis CI for python 3: https://travis-ci.org/agoodm/climate/jobs/204421839 You can merge this pull request into a Git repository by running: $ git pull https://github.com/agoodm/climate CLIMATE-897 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/427.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #427
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/climate/pull/427

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/climate/pull/427

            People

            • Assignee:
              agoodman Alex Goodman
              Reporter:
              agoodman Alex Goodman
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development