Uploaded image for project: 'Apache Open Climate Workbench (Retired)'
  1. Apache Open Climate Workbench (Retired)
  2. CLIMATE-261

Consolidate Code that converts a String into a Datetime Object

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Not A Problem
    • 0.2-incubating
    • 0.4
    • analysis
    • None
    • *nix

    Description

      Currently there are two copies of the same functionality within the rcmes module. These two functions are almost line for line the same code.

      rcmes.toolkit.process.decodeTimeFromString(time_string)
      vs.
      rcmes.services.decode_model_times.decodeTimeFromString(time_string)

      Since this seems like useful functionality we should pull it into the ocw package once the Refactoring Branch has been merged into the trunk.

      When the final implementation of this feature is written, these two functions will need to updated to call the canonical implementation at the least.

      The best approach would be to find and replace all places in the code that these functions are called, and update those places to call the new implementation.

      The code also needs to raise an exception if it is unable to parse the input string instead of just returning 0.

      Task Plan:
      =============
      1. Develop a Canonical function within ocw to handle parsing a string into a Python Datetime object
      2. Ensure the new function is unit tested and Raises an error when unable to Parse the string. ValueError?
      3. Update the two functions listed in this issue so they use the new function within ocw
      4. Add deprecation docstrings to the functions

      Attachments

        Activity

          People

            cgoodale Cameron Goodale
            cgoodale Cameron Goodale
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: