[CLI-300] DefaultParser fails to parse token "-S=V" if short option is longer than 1 char

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.4
• Component/s: Parser

Environment

Windows 10, Java 11

• Assignee: Unassigned
• Reporter: Balz Guenat
• Created: 22/Nov/19 09:42
• Updated: 16/Jun/20 09:20

Description

Assuming there is a short option with foo with one argument. Trying to parse a token like -foo=bar results in an UnrecognizedOptionException.

The same scenario works fine if the short option is only one char long.

The reason is an if-statement in DefaultParser.handleShortAndLongOption() (line 543 in v1.4), which checks opt.length() == 1 before checking if the option exists. IMO, this check should instead be isShortOption(opt).

The below code demonstrates the issue.

Options options = new Options();
Option option = Option.builder("foo").hasArg().build();
options.addOption(option);

String[] args = new String[] {"-foo=bar"};

DefaultParser parser = new DefaultParser();
CommandLine cmdLine = parser.parse(options, args);

assertEquals("bar", cmdLine.getOptionValue("foo"));