Uploaded image for project: 'Commons CLI'
  1. Commons CLI
  2. CLI-231

Remove DoubleCheckedLocking from checkstyle configuration

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3
    • Component/s: CLI-1.x
    • Labels:

      Description

      Checkstyle v5.6 removed the DoubleCheckedLocking test (see release notes). Consequently, the checkstyle.xml configuration file now fails to process with v5.6 (which is used by the Eclipse checkstyle plugin).

      Could we remove this check?

      1. cli-231.patch
        0.6 kB
        Duncan Jones

        Activity

        Hide
        dmjones500 Duncan Jones added a comment -

        Patch file to remove check.

        Show
        dmjones500 Duncan Jones added a comment - Patch file to remove check.
        Hide
        tn Thomas Neidhart added a comment -

        I noticed this already myself, and I think it is fine to remove it as there is no occurrence of such a pattern in the code anyway.

        Show
        tn Thomas Neidhart added a comment - I noticed this already myself, and I think it is fine to remove it as there is no occurrence of such a pattern in the code anyway.
        Hide
        tn Thomas Neidhart added a comment -

        Applied in r1447004.

        Show
        tn Thomas Neidhart added a comment - Applied in r1447004.

          People

          • Assignee:
            Unassigned
            Reporter:
            dmjones500 Duncan Jones
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development