Uploaded image for project: 'Commons CLI'
  1. Commons CLI
  2. CLI-214

Option(String, String) constructor not mirrored by Options.addOption

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.3
    • Component/s: CLI-1.x
    • Labels:
      None

      Description

      Option has three constructors. Options has several "addOption" methods that obviously are intended to mirror the Option constructors, but there are only two; the one with two strings is missing. It would be nice to fix this inconsistency.

      1. cli_214.patch
        0.8 kB
        Alexandru Mocanu

        Activity

        Hide
        kaisar Alexandru Mocanu added a comment - - edited

        I agree, the symmetry should probably be conserved. I attached a patch for it anyway.

        Show
        kaisar Alexandru Mocanu added a comment - - edited I agree, the symmetry should probably be conserved. I attached a patch for it anyway.
        Hide
        tn Thomas Neidhart added a comment -

        Applied patch in r1442985.

        Thanks for the report and the patch!

        Show
        tn Thomas Neidhart added a comment - Applied patch in r1442985. Thanks for the report and the patch!

          People

          • Assignee:
            Unassigned
            Reporter:
            wboyce@panix.com Willis Blackburn
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development