Uploaded image for project: 'Commons CLI'
  1. Commons CLI
  2. CLI-135

Backwards compatibility between 1.1 and 1.0 broken due to Option.addValue removal

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 1.1
    • Component/s: CLI-1.x
    • Labels:
      None

      Description

      ERROR: 7006: org.apache.commons.cli.Option: Return type of method 'public boolean addValue(java.lang.String)' has been changed to void
      ERROR: 7009: org.apache.commons.cli.Option: Accessibility of method 'public boolean addValue(java.lang.String)' has been decreased from public to
      package

      1. CLI-135-2nd.patch
        0.6 kB
        Henri Yandell
      2. CLI-135.patch
        3 kB
        Henri Yandell

        Activity

        Hide
        bayard Henri Yandell added a comment -

        First step is to change the package private addValue variant so it no longer clashes.

        Second step is to put back the old addValue method in some non-useful way.

        Show
        bayard Henri Yandell added a comment - First step is to change the package private addValue variant so it no longer clashes. Second step is to put back the old addValue method in some non-useful way.
        Hide
        bayard Henri Yandell added a comment -

        Attaching a patch to do both of these. The new method is addValueForProcessing.

        Show
        bayard Henri Yandell added a comment - Attaching a patch to do both of these. The new method is addValueForProcessing.
        Hide
        bayard Henri Yandell added a comment -

        Got the parameter wrong on the new/old addValue. I did Object, should have been String. This patch fixes that.

        Show
        bayard Henri Yandell added a comment - Got the parameter wrong on the new/old addValue. I did Object, should have been String. This patch fixes that.
        Hide
        bayard Henri Yandell added a comment -

        Patches applied. Clirr no longer errors.

        Show
        bayard Henri Yandell added a comment - Patches applied. Clirr no longer errors.

          People

          • Assignee:
            Unassigned
            Reporter:
            bayard Henri Yandell
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development