Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-9

MetricDataLoader should close JDBC connection

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.1.2
    • Component/s: None
    • Labels:
      None

      Description

      MetricDataLoader is not closing the JDBC connection

      1. CHUKWA-9.patch
        0.6 kB
        Jerome Boulon
      2. HADOOP-5431.patch
        0.8 kB
        Jerome Boulon

        Activity

        Hide
        asrabkin Ari Rabkin added a comment -

        Looks okay. Probably hard to unit test this, since it depends on there being a database to talk to. +1 pending Hudson.

        Show
        asrabkin Ari Rabkin added a comment - Looks okay. Probably hard to unit test this, since it depends on there being a database to talk to. +1 pending Hudson.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this; thanks Jerome!

        [didn't wait for autobuild test, since we don't have unit test coverage of this component, anyway.]

        Show
        asrabkin Ari Rabkin added a comment - I just committed this; thanks Jerome! [didn't wait for autobuild test, since we don't have unit test coverage of this component, anyway.]
        Hide
        asrabkin Ari Rabkin added a comment -

        Ack. Patch didn't apply right after all (my working tree was stale.)

        Jerome, can you regenerate this patch?

        Show
        asrabkin Ari Rabkin added a comment - Ack. Patch didn't apply right after all (my working tree was stale.) Jerome, can you regenerate this patch?
        Hide
        jboulon Jerome Boulon added a comment -

        I'm waiting for the build to fixed then I will regenerate that patch.

        Show
        jboulon Jerome Boulon added a comment - I'm waiting for the build to fixed then I will regenerate that patch.
        Hide
        jboulon Jerome Boulon added a comment -

        CHUKWA-9.patch based on current CHUKWA tree

        Show
        jboulon Jerome Boulon added a comment - CHUKWA-9 .patch based on current CHUKWA tree
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this.
        Thanks, Jerome!

        Show
        asrabkin Ari Rabkin added a comment - I just committed this. Thanks, Jerome!

          People

          • Assignee:
            jboulon Jerome Boulon
            Reporter:
            jboulon Jerome Boulon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development