Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.7.0
    • Fix Version/s: None
    • Component/s: Build and Test Code
    • Labels:
      None

      Activity

      Hide
      anna.peiyu.wang Anna Wang added a comment -

      Upgrade maven-surefire version to 2.18.1

      Show
      anna.peiyu.wang Anna Wang added a comment - Upgrade maven-surefire version to 2.18.1
      Hide
      eyang Eric Yang added a comment -

      Hi Anna,

      Thank you for submitting the patch. Could you clarify the reason to make some of the code changes about System.exit(-1)?

      Show
      eyang Eric Yang added a comment - Hi Anna, Thank you for submitting the patch. Could you clarify the reason to make some of the code changes about System.exit(-1)?
      Hide
      anna.peiyu.wang Anna Wang added a comment -

      I encountered the following issue when I upgraded the maven-surefire-version to 2.18.1.
      [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project plenty: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?

      I found there are several files contain "System.exit" in both test or production code. Instead of calling System.exit, we should just throw an exception or do a return.

      Show
      anna.peiyu.wang Anna Wang added a comment - I encountered the following issue when I upgraded the maven-surefire-version to 2.18.1. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project plenty: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called? I found there are several files contain "System.exit" in both test or production code. Instead of calling System.exit, we should just throw an exception or do a return.
      Hide
      eyang Eric Yang added a comment -

      +1 looks good.

      Show
      eyang Eric Yang added a comment - +1 looks good.
      Hide
      eyang Eric Yang added a comment -

      I just committed this. Thanks Anna.

      Show
      eyang Eric Yang added a comment - I just committed this. Thanks Anna.
      Hide
      anna.peiyu.wang Anna Wang added a comment -

      Thanks Eric

      Show
      anna.peiyu.wang Anna Wang added a comment - Thanks Eric

        People

        • Assignee:
          anna.peiyu.wang Anna Wang
          Reporter:
          anna.peiyu.wang Anna Wang
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development