Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-74

Agent shouldn't log exceptions for down collectors

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.3.0
    • Component/s: Input Tools
    • Labels:
      None

      Description

      To reduce the agent log volume, it should only log that it failed to connect to a collector at the ERROR level and log the exception and stack trace to DEBUG level.

        Activity

        Hide
        rushinbarotsjsu rushin barot added a comment -

        more details on the description ?

        Show
        rushinbarotsjsu rushin barot added a comment - more details on the description ?
        Hide
        asrabkin Ari Rabkin added a comment -

        I believe the offending line is line 206 in org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender

        Should just log that an exception happened, not dump the stack trace.

        Show
        asrabkin Ari Rabkin added a comment - I believe the offending line is line 206 in org.apache.hadoop.chukwa.datacollection.sender.ChukwaHttpSender Should just log that an exception happened, not dump the stack trace.
        Hide
        rushinbarotsjsu rushin barot added a comment -

        stack trace to debug level

        Show
        rushinbarotsjsu rushin barot added a comment - stack trace to debug level
        Hide
        asrabkin Ari Rabkin added a comment -

        I think that the serialization failure is a real error – the serialization happens before we ever start talking to the collector; if it throws an exception, that's a bug. So I think that should be logged with stack trace.

        Show
        asrabkin Ari Rabkin added a comment - I think that the serialization failure is a real error – the serialization happens before we ever start talking to the collector; if it throws an exception, that's a bug. So I think that should be logged with stack trace.
        Hide
        rushinbarotsjsu rushin barot added a comment -

        updated .. thanks

        Show
        rushinbarotsjsu rushin barot added a comment - updated .. thanks
        Hide
        asrabkin Ari Rabkin added a comment -

        +1. I'll commit this tonight or tomorrow.

        Show
        asrabkin Ari Rabkin added a comment - +1. I'll commit this tonight or tomorrow.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this. Thanks, Rushin!

        Show
        asrabkin Ari Rabkin added a comment - I just committed this. Thanks, Rushin!
        Hide
        hudson Hudson added a comment -
        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #112 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/112/ )

          People

          • Assignee:
            rushinbarotsjsu rushin barot
            Reporter:
            macyang Mac Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development