Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-649

To handle pid-file missing case while stoping chukwa processes

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.4.0, 0.6.0
    • Fix Version/s: None
    • Component/s: Scripts
    • Labels:
      None

      Description

      If the pid-file is missing accidentally, the stop script will print out usage prompt of "kill" command. It is quite confused for the end user. The simple fix is to check that pid-file before executing kill command.

      1. Chukwa-649-0_4_v2.patch
        0.5 kB
        Jie Huang
      2. Chukwa-649-0_4.patch
        0.4 kB
        Jie Huang
      3. Chukwa-649-0_6.patch
        0.5 kB
        Jie Huang

        Activity

        Hide
        grace.huang Jie Huang added a comment -

        Simple fix. Or we can make it better. like adding some “if-else” clause with more prompts. If it is necessary, I will refine it. Any idea?

        Show
        grace.huang Jie Huang added a comment - Simple fix. Or we can make it better. like adding some “if-else” clause with more prompts. If it is necessary, I will refine it. Any idea?
        Hide
        asrabkin Ari Rabkin added a comment -

        I think it would be better to explicitly tell the user if there's nothing to kill.
        Possible wording: "No PID file found; not killing. Perhaps Chukwa was not running?"

        Show
        asrabkin Ari Rabkin added a comment - I think it would be better to explicitly tell the user if there's nothing to kill. Possible wording: "No PID file found; not killing. Perhaps Chukwa was not running?"
        Hide
        grace.huang Jie Huang added a comment -

        Yes. I will update the patch accordingly.

        Show
        grace.huang Jie Huang added a comment - Yes. I will update the patch accordingly.
        Hide
        grace.huang Jie Huang added a comment -

        Does it look better?

        Show
        grace.huang Jie Huang added a comment - Does it look better?
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this change to Trunk. Thanks, Jie.

        Unless somebody tells me otherwise, I am assuming we have no intention to do a new 0.4 release; as a result, I think we don't need to produce or commit patches to that branch.

        Show
        asrabkin Ari Rabkin added a comment - I just committed this change to Trunk. Thanks, Jie. Unless somebody tells me otherwise, I am assuming we have no intention to do a new 0.4 release; as a result, I think we don't need to produce or commit patches to that branch.
        Hide
        hudson Hudson added a comment -

        Integrated in Chukwa-trunk #454 (See https://builds.apache.org/job/Chukwa-trunk/454/)
        CHUKWA-649. Handle pid-file missing case while stoping chukwa processes. Contributed by Jie Huang. (Revision 1364418)

        Result = SUCCESS
        asrabkin : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1364418
        Files :

        • /incubator/chukwa/trunk/CHANGES.txt
        • /incubator/chukwa/trunk/bin/chukwa
        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #454 (See https://builds.apache.org/job/Chukwa-trunk/454/ ) CHUKWA-649 . Handle pid-file missing case while stoping chukwa processes. Contributed by Jie Huang. (Revision 1364418) Result = SUCCESS asrabkin : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1364418 Files : /incubator/chukwa/trunk/CHANGES.txt /incubator/chukwa/trunk/bin/chukwa
        Hide
        grace.huang Jie Huang added a comment -

        Thanks. I will move all my patch work against the latest version now.

        Show
        grace.huang Jie Huang added a comment - Thanks. I will move all my patch work against the latest version now.

          People

          • Assignee:
            Unassigned
            Reporter:
            grace.huang Jie Huang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development