Chukwa
  1. Chukwa
  2. CHUKWA-58

Watchdog is using $CHUKWA_HOME while PidFile.java is using CHUKWA_PID_DIR

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      PidFile is using this logic to found where to create the pid file.

      String chukwaPath = System.getProperty("CHUKWA_HOME");
      StringBuffer pidFilesb = new StringBuffer();
      String pidDir = System.getenv("CHUKWA_PID_DIR");
      if (pidDir == null)

      { pidDir = chukwaPath + File.separator + "var" + File.separator + "run"; }

      Watchdog should do something similar instead of using CHUKWA_HOME.
      Also, watchdog is difficult to maintain so will be good to create one function that is doing all the necessary steps
      and call that function for all processes that watchdog should watch for.

        Activity

        Hide
        Eric Yang added a comment -

        Corrected watchdog to look for CHUKWA_PID_DIR.

        Show
        Eric Yang added a comment - Corrected watchdog to look for CHUKWA_PID_DIR.
        Hide
        Eric Yang added a comment -

        Changed watchdog to look for CHUKWA_PID_DIR.

        Show
        Eric Yang added a comment - Changed watchdog to look for CHUKWA_PID_DIR.
        Hide
        Ari Rabkin added a comment -

        +1

        Show
        Ari Rabkin added a comment - +1
        Hide
        Eric Yang added a comment -

        Thanks Ari, I just committed this.

        Show
        Eric Yang added a comment - Thanks Ari, I just committed this.

          People

          • Assignee:
            Eric Yang
            Reporter:
            Jerome Boulon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development