Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-562

Use RegexFileFilter instead of WildcardFileFilter in the DirTailingAdaptor class

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.5.0
    • Component/s: Data Collection
    • Labels:
      None

      Description

      The DirTailingAdaptor class uses WildcardFileFilter to filter the files that need to be monitored. The WildcardFileFilter is NOT very restrictive. Instead of WildcardFileFilter using RegexFileFilter will give user more flexibility in file filtering.

      1. DirTailingAdaptor.patch
        1 kB
        Deepak Deshpande
      2. RegExDirTailingAdaptor.java
        1 kB
        Deepak Deshpande

        Activity

        Hide
        asrabkin Ari Rabkin added a comment -

        I'm uneasy with this patch. I think regular expressions are slightly less intuitive for most users. Moreover, this breaks the existing user interface. Deepak, how would you feel about instead having a subclass of DirTailingAdaptor with regex patterns?

        Show
        asrabkin Ari Rabkin added a comment - I'm uneasy with this patch. I think regular expressions are slightly less intuitive for most users. Moreover, this breaks the existing user interface. Deepak, how would you feel about instead having a subclass of DirTailingAdaptor with regex patterns?
        Hide
        eyang Eric Yang added a comment -

        +1 on RegExDirTailingAdaptor.

        Show
        eyang Eric Yang added a comment - +1 on RegExDirTailingAdaptor.
        Hide
        dpkdshp Deepak Deshpande added a comment -

        I am ok with that approach. I will have to modify DirTailingAdaptor class so that I can extend him and override some of his attributes. Let me resubmit the patch with these suggestions. - Deepak.

        Show
        dpkdshp Deepak Deshpande added a comment - I am ok with that approach. I will have to modify DirTailingAdaptor class so that I can extend him and override some of his attributes. Let me resubmit the patch with these suggestions. - Deepak.
        Hide
        eyang Eric Yang added a comment -

        +1 looks good, I just committed this.

        Show
        eyang Eric Yang added a comment - +1 looks good, I just committed this.
        Hide
        eyang Eric Yang added a comment -

        Thanks Deepak.

        Show
        eyang Eric Yang added a comment - Thanks Deepak.

          People

          • Assignee:
            Unassigned
            Reporter:
            dpkdshp Deepak Deshpande
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development