Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-553

DirTailingAdaptor doesn't honor the file filter correctly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: None
    • Component/s: Data Collection
    • Labels:
      None
    • Environment:

      Redhat Linux 5.2

    • Release Note:
      Changes format of DirTailingAdaptor checkpoint entry

      Description

      The DirTailingAdaptor doesn't honor the file filter correctly. After first restart of Chukwa agent, the DirTailingAdaptor is starting an adaptor for files that don't match the filter provided. After little research, I found that the check point file for DirTailingAdaptor doesn't have the file filter argument provided by user. The bug is in "getCurrentStatus" method and it doesn't return the file pattern provided by user in the returned String. I was able to fix the issue by returning the file pattern in the returned String.

        Activity

        Hide
        eyang Eric Yang added a comment -

        Ari, this is not compatible with existing DirTailingAdaptor checkpoint file. I am ok with this change, how about you?

        Show
        eyang Eric Yang added a comment - Ari, this is not compatible with existing DirTailingAdaptor checkpoint file. I am ok with this change, how about you?
        Hide
        asrabkin Ari Rabkin added a comment -

        Yes. I'm happy to change checkpoint file formats. But that definitely requires a release note.

        Show
        asrabkin Ari Rabkin added a comment - Yes. I'm happy to change checkpoint file formats. But that definitely requires a release note.
        Hide
        eyang Eric Yang added a comment -

        Could you regenerate the patch with +u option It would be easier to apply. Thanks.

        Show
        eyang Eric Yang added a comment - Could you regenerate the patch with +u option It would be easier to apply. Thanks.
        Hide
        dpkdshp Deepak Deshpande added a comment -

        Can you please explain what exactly you want me to do. Unfortunately, I have Windows OS and generated this patch on it. Please explain what you would like me to do and I would be happy to do it. Thanks.

        Show
        dpkdshp Deepak Deshpande added a comment - Can you please explain what exactly you want me to do. Unfortunately, I have Windows OS and generated this patch on it. Please explain what you would like me to do and I would be happy to do it. Thanks.
        Hide
        eyang Eric Yang added a comment -

        When you use the diff command, supply +u command and it will generate the patch which shows:

        • line 1 old
          + line 1 new

        instead of

        < line 1 old
        > line 1 new

        This will make patching easier. I am not exactly sure what option it would be on Windows's diff command. You might need to look up the help for the diff command.

        Thanks

        Show
        eyang Eric Yang added a comment - When you use the diff command, supply +u command and it will generate the patch which shows: line 1 old + line 1 new instead of < line 1 old > line 1 new This will make patching easier. I am not exactly sure what option it would be on Windows's diff command. You might need to look up the help for the diff command. Thanks
        Hide
        dpkdshp Deepak Deshpande added a comment -

        Attaching new file with Patch format as requested by Eric

        Show
        dpkdshp Deepak Deshpande added a comment - Attaching new file with Patch format as requested by Eric
        Hide
        dpkdshp Deepak Deshpande added a comment -

        Eric, Please take a look at new patch file. Thanks.

        Show
        dpkdshp Deepak Deshpande added a comment - Eric, Please take a look at new patch file. Thanks.
        Hide
        eyang Eric Yang added a comment -

        +1 looks good.

        Show
        eyang Eric Yang added a comment - +1 looks good.
        Hide
        eyang Eric Yang added a comment -

        I just committed this, thanks Deepak

        Show
        eyang Eric Yang added a comment - I just committed this, thanks Deepak

          People

          • Assignee:
            Unassigned
            Reporter:
            dpkdshp Deepak Deshpande
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development