Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-489

Malformed SQL generated in MetricDataLoader when values contain single quote character

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: None
    • Component/s: DB Data Processors
    • Labels:
      None

      Description

      When our demux creates ChukwaRecord entries whose values contain single quotes, the SQL generated by MetricDataLoader is invalid as the single quote character is not being properly escaped. There's already an escape method present, and adding two lines of code fixed it for us.

      Patch forthcoming...

        Activity

        Hide
        kirktrue Kirk True added a comment -

        Patch to implement proper handling of single quote characters.

        Show
        kirktrue Kirk True added a comment - Patch to implement proper handling of single quote characters.
        Hide
        eyang Eric Yang added a comment -

        +1 Looks good.

        Show
        eyang Eric Yang added a comment - +1 Looks good.
        Hide
        eyang Eric Yang added a comment -

        Thanks Kirk, I just committed this.

        Show
        eyang Eric Yang added a comment - Thanks Kirk, I just committed this.
        Hide
        hudson Hudson added a comment -

        Integrated in Chukwa-trunk #401 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/401/)
        Updated Change log for CHUKWA-489 and CHUKWA-490.
        CHUKWA-489. Fixed malformed SQL in MetricDataLoader when values contain single quote character. (Kirk True via Eric Yang)

        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #401 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/401/ ) Updated Change log for CHUKWA-489 and CHUKWA-490 . CHUKWA-489 . Fixed malformed SQL in MetricDataLoader when values contain single quote character. (Kirk True via Eric Yang)

          People

          • Assignee:
            eyang Eric Yang
            Reporter:
            kirktrue Kirk True
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development