Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Release Note:
      Adaptors marked with adaptor_ prefix.

      Description

      Right now, the chukwa logs are fairly inconsistent in nomenclature. This patch addresses this.

      1. CHUKWA-418.patch
        18 kB
        Ari Rabkin
      2. CHUKWA-418b.patch
        2 kB
        Ari Rabkin
      3. moreLogFixes.patch
        5 kB
        Ari Rabkin

        Activity

        Hide
        asrabkin Ari Rabkin added a comment -

        A major change in this patch is that adaptor names all start with adaptor_. This property is enforced at adaptor creation time – if an adaptor name lacks that prefix, it is added.

        The main motive for this change was to make the logs easier to read and parse. It is also more consistent with the style of Hadoop identifiers.

        Show
        asrabkin Ari Rabkin added a comment - A major change in this patch is that adaptor names all start with adaptor_. This property is enforced at adaptor creation time – if an adaptor name lacks that prefix, it is added. The main motive for this change was to make the logs easier to read and parse. It is also more consistent with the style of Hadoop identifiers.
        Hide
        eyang Eric Yang added a comment -

        While uniformity is good, we should be consistent in using pascal case or camel case.
        My vote is to use pascal case for shell script, and camel case for java. What do you think?

        Show
        eyang Eric Yang added a comment - While uniformity is good, we should be consistent in using pascal case or camel case. My vote is to use pascal case for shell script, and camel case for java. What do you think?
        Hide
        asrabkin Ari Rabkin added a comment -

        Eric, I'm not quite sure I understand the context of your comment. Pascal or Camel case for what?

        The logic of using "adaptor_" as a marker for adaptor IDs is that it's consistent with the way Hadoop marks its identifiers – it looks like "job_" and "task_" and so forth.

        Show
        asrabkin Ari Rabkin added a comment - Eric, I'm not quite sure I understand the context of your comment. Pascal or Camel case for what? The logic of using "adaptor_" as a marker for adaptor IDs is that it's consistent with the way Hadoop marks its identifiers – it looks like "job_" and "task_" and so forth.
        Hide
        eyang Eric Yang added a comment -

        I misunderstood what you tried to accomplish. I thought this change applies to adaptor type which was also referred by adaptor name in the past. The change makes sense. +1.

        Show
        eyang Eric Yang added a comment - I misunderstood what you tried to accomplish. I thought this change applies to adaptor type which was also referred by adaptor name in the past. The change makes sense. +1.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this.

        Show
        asrabkin Ari Rabkin added a comment - I just committed this.
        Hide
        asrabkin Ari Rabkin added a comment -

        Should update documentation to explain this.

        Show
        asrabkin Ari Rabkin added a comment - Should update documentation to explain this.
        Hide
        asrabkin Ari Rabkin added a comment -

        Revise documentation. Correct a typo in the code.

        I will commit this tomorrow, barring objection. It's a small change, with no functional implications.

        Show
        asrabkin Ari Rabkin added a comment - Revise documentation. Correct a typo in the code. I will commit this tomorrow, barring objection. It's a small change, with no functional implications.
        Hide
        hudson Hudson added a comment -
        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #216 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/216/ )
        Hide
        asrabkin Ari Rabkin added a comment -

        Just committed this fix. (Forgot to document it in commit message, though. )

        Show
        asrabkin Ari Rabkin added a comment - Just committed this fix. (Forgot to document it in commit message, though. )
        Hide
        asrabkin Ari Rabkin added a comment -

        want to do more revisions

        Show
        asrabkin Ari Rabkin added a comment - want to do more revisions
        Hide
        asrabkin Ari Rabkin added a comment -

        Add a "post ID" to help link together various messages about a particular HTTP post.

        Show
        asrabkin Ari Rabkin added a comment - Add a "post ID" to help link together various messages about a particular HTTP post.
        Hide
        asrabkin Ari Rabkin added a comment -

        It's small changes to logging, so I will commit within a few days, barring objection.

        Show
        asrabkin Ari Rabkin added a comment - It's small changes to logging, so I will commit within a few days, barring objection.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this.

        Show
        asrabkin Ari Rabkin added a comment - I just committed this.
        Hide
        hudson Hudson added a comment -

        Integrated in Chukwa-trunk #225 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/225/)
        . More logging enhancement

        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #225 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/225/ ) . More logging enhancement

          People

          • Assignee:
            asrabkin Ari Rabkin
            Reporter:
            asrabkin Ari Rabkin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development