Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-407

In socketTeeWriter PatternSyntaxException exceptions aren't sent to the client properly

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.3.0
    • Component/s: Data Collection
    • Labels:
      None

      Description

      inside SockteTeeWriter.Tee.setup(), the output steam should be created
      early on in order for parser exceptions to be properly sent to the
      client.

      the patch is to simply move the creation of the output stream up like this:

      in = new BufferedReader(new InputStreamReader(sock.getInputStream()));
      out = new DataOutputStream(sock.getOutputStream());

      ....

      rules = new Filter(cmdAfterSpace);

      1. CHUKWA-1234.patch
        1.0 kB
        thushara wijeratna

        Activity

        Hide
        asrabkin Ari Rabkin added a comment -

        Yep. That's a bug, and that's a sensible fix. Can you attach an actual patch, generated with svn diff in the root Chukwa directory?

        Show
        asrabkin Ari Rabkin added a comment - Yep. That's a bug, and that's a sensible fix. Can you attach an actual patch, generated with svn diff in the root Chukwa directory?
        Hide
        asrabkin Ari Rabkin added a comment -

        Patch looks good. I'll commit it tomorrow, barring objection. As a bug-fix, I think it can go on branch-0.3 as well as TRUNK.

        For future reference, it's helpful that the file names for patches match the issue number or describe the content – "CHUKWA-407", rather than "-1234"

        Show
        asrabkin Ari Rabkin added a comment - Patch looks good. I'll commit it tomorrow, barring objection. As a bug-fix, I think it can go on branch-0.3 as well as TRUNK. For future reference, it's helpful that the file names for patches match the issue number or describe the content – " CHUKWA-407 ", rather than "-1234"
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this. Thanks, Thushara!

        Committed to both branch and trunk – it's a bugfix, so it's appropriate for a branch. However, I don't think this is significant enough to abandon the current release candidate.

        Show
        asrabkin Ari Rabkin added a comment - I just committed this. Thanks, Thushara! Committed to both branch and trunk – it's a bugfix, so it's appropriate for a branch. However, I don't think this is significant enough to abandon the current release candidate.

          People

          • Assignee:
            Unassigned
            Reporter:
            thushara thushara wijeratna
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development