Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-379

refactor sender

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: Data Processors
        • Labels:
          None

          Description

          Make Sender more modular, make RetryListOfCollectors self-configuring

          1. Text File
            refactor.patch
            8 kB
            Ari Rabkin
          2. Text File
            refactoring.patch
            17 kB
            Ari Rabkin

            Issue Links

            is depended upon by

            New Feature - A new feature of the product, which has yet to be developed. CHUKWA-369 proposed reliability mechanism

            • Major - Major loss of function.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              asrabkin Ari Rabkin added a comment -

              In the course of working on CHUKWA-369, I found myself doing a fair bit of refactoring of the sender and retryList code. I think these changes are useful and worth making, regardless of what happens with CHUKWA-369.

              Show
              asrabkin Ari Rabkin added a comment - In the course of working on CHUKWA-369 , I found myself doing a fair bit of refactoring of the sender and retryList code. I think these changes are useful and worth making, regardless of what happens with CHUKWA-369 .
              Hide
              Permalink
              asrabkin Ari Rabkin added a comment -

              tweak logging slightly, add a hook for downed collector detection.

              Show
              asrabkin Ari Rabkin added a comment - tweak logging slightly, add a hook for downed collector detection.
              Hide
              Permalink
              eyang Eric Yang added a comment -

              +1 looks good.

              Show
              eyang Eric Yang added a comment - +1 looks good.
              Hide
              Permalink
              asrabkin Ari Rabkin added a comment -

              I just committed this; thanks for the prompt review, Eric.

              Show
              asrabkin Ari Rabkin added a comment - I just committed this; thanks for the prompt review, Eric.
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Chukwa-trunk #113 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/113/)
              . Refactor sender code.

              Show
              hudson Hudson added a comment - Integrated in Chukwa-trunk #113 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/113/ ) . Refactor sender code.
              Hide
              Permalink
              asrabkin Ari Rabkin added a comment -

              Another small batch of API changes, mostly around RetryListOfCollectors.

              Show
              asrabkin Ari Rabkin added a comment - Another small batch of API changes, mostly around RetryListOfCollectors.
              Hide
              Permalink
              asrabkin Ari Rabkin added a comment -

              Pretty small changes, passes unit tests locally. Will commit tomorrow, barring objection.

              Show
              asrabkin Ari Rabkin added a comment - Pretty small changes, passes unit tests locally. Will commit tomorrow, barring objection.
              Hide
              Permalink
              asrabkin Ari Rabkin added a comment -

              Just committed this.

              Show
              asrabkin Ari Rabkin added a comment - Just committed this.
              Hide
              Permalink
              hudson Hudson added a comment -

              Integrated in Chukwa-trunk #120 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/120/)
              . More refactoring

              Show
              hudson Hudson added a comment - Integrated in Chukwa-trunk #120 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/120/ ) . More refactoring

                People

                • Assignee:
                  asrabkin Ari Rabkin
                  Reporter:
                  asrabkin Ari Rabkin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development