Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Data Processors
    • Labels:
      None

      Description

      Make Sender more modular, make RetryListOfCollectors self-configuring

      1. refactoring.patch
        17 kB
        Ari Rabkin
      2. refactor.patch
        8 kB
        Ari Rabkin

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in Chukwa-trunk #120 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/120/)
          . More refactoring

          Show
          hudson Hudson added a comment - Integrated in Chukwa-trunk #120 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/120/ ) . More refactoring
          Hide
          asrabkin Ari Rabkin added a comment -

          Just committed this.

          Show
          asrabkin Ari Rabkin added a comment - Just committed this.
          Hide
          asrabkin Ari Rabkin added a comment -

          Pretty small changes, passes unit tests locally. Will commit tomorrow, barring objection.

          Show
          asrabkin Ari Rabkin added a comment - Pretty small changes, passes unit tests locally. Will commit tomorrow, barring objection.
          Hide
          asrabkin Ari Rabkin added a comment -

          Another small batch of API changes, mostly around RetryListOfCollectors.

          Show
          asrabkin Ari Rabkin added a comment - Another small batch of API changes, mostly around RetryListOfCollectors.
          Hide
          hudson Hudson added a comment -

          Integrated in Chukwa-trunk #113 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/113/)
          . Refactor sender code.

          Show
          hudson Hudson added a comment - Integrated in Chukwa-trunk #113 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/113/ ) . Refactor sender code.
          Hide
          asrabkin Ari Rabkin added a comment -

          I just committed this; thanks for the prompt review, Eric.

          Show
          asrabkin Ari Rabkin added a comment - I just committed this; thanks for the prompt review, Eric.
          Hide
          eyang Eric Yang added a comment -

          +1 looks good.

          Show
          eyang Eric Yang added a comment - +1 looks good.
          Hide
          asrabkin Ari Rabkin added a comment -

          tweak logging slightly, add a hook for downed collector detection.

          Show
          asrabkin Ari Rabkin added a comment - tweak logging slightly, add a hook for downed collector detection.
          Hide
          asrabkin Ari Rabkin added a comment -

          In the course of working on CHUKWA-369, I found myself doing a fair bit of refactoring of the sender and retryList code. I think these changes are useful and worth making, regardless of what happens with CHUKWA-369.

          Show
          asrabkin Ari Rabkin added a comment - In the course of working on CHUKWA-369 , I found myself doing a fair bit of refactoring of the sender and retryList code. I think these changes are useful and worth making, regardless of what happens with CHUKWA-369 .

            People

            • Assignee:
              asrabkin Ari Rabkin
              Reporter:
              asrabkin Ari Rabkin
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development