Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-335

Discard Meta line in the job history log file

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.2.0, 0.3.0
    • Fix Version/s: 0.3.0
    • Component/s: None
    • Labels:
      None

      Description

      Meta line doesn't have time stamp. Currently all meta will be put to /chukwa/repos/cluster/19700101. It causes many small one line file in the same dir.

      1. chukwa-335.patch
        0.6 kB
        Cheng
      2. CHUKWA-335-1.patch
        1.0 kB
        Eric Yang

        Activity

        Hide
        zhangyongjiang Cheng added a comment -

        patch provided. "Meta" line is ignored when processing job history data.

        Show
        zhangyongjiang Cheng added a comment - patch provided. "Meta" line is ignored when processing job history data.
        Hide
        asrabkin Ari Rabkin added a comment -

        +1.

        I would be happy to declare this a bug fix, and also commit to 0.2.

        Show
        asrabkin Ari Rabkin added a comment - +1. I would be happy to declare this a bug fix, and also commit to 0.2.
        Hide
        asrabkin Ari Rabkin added a comment -

        This reviewable, and I think also committable. But I want to know if it should go into 0.2

        Show
        asrabkin Ari Rabkin added a comment - This reviewable, and I think also committable. But I want to know if it should go into 0.2
        Hide
        eyang Eric Yang added a comment -

        We are running stress test on 0.2, and the build holds for 2 days so far.
        The severity of this issue is not a blocker. Therefore, this is good for trunk.

        Show
        eyang Eric Yang added a comment - We are running stress test on 0.2, and the build holds for 2 days so far. The severity of this issue is not a blocker. Therefore, this is good for trunk.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this to trunk. Thanks, Cheng!

        Show
        asrabkin Ari Rabkin added a comment - I just committed this to trunk. Thanks, Cheng!
        Hide
        asrabkin Ari Rabkin added a comment -

        This change broke TestJobLogEntry.

        Show
        asrabkin Ari Rabkin added a comment - This change broke TestJobLogEntry.
        Hide
        eyang Eric Yang added a comment -

        Removed test case for meta line, since we don't store this line in chukwa records.

        Show
        eyang Eric Yang added a comment - Removed test case for meta line, since we don't store this line in chukwa records.
        Hide
        eyang Eric Yang added a comment -

        Updated test case to reflect the code change.

        Show
        eyang Eric Yang added a comment - Updated test case to reflect the code change.
        Hide
        asrabkin Ari Rabkin added a comment -

        +1

        Show
        asrabkin Ari Rabkin added a comment - +1
        Hide
        eyang Eric Yang added a comment -

        I just committed this. Thanks Ari.

        Show
        eyang Eric Yang added a comment - I just committed this. Thanks Ari.

          People

          • Assignee:
            eyang Eric Yang
            Reporter:
            zhangyongjiang Cheng
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development