Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-33

Adapt chukwa code to hadoop codestyle

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      It seems large parts of the Chukwa code doesn't conform to the Hadoop code style, we should reformat it to fit the rest of the project.
      "Code should be formatted according to Sun's conventions, with one exception: Indent two spaces per level, not four."

        Activity

        Hide
        johanoskarsson Johan Oskarsson added a comment -

        I'm assuming the contrib directories should conform to the Hadoop guidelines, if not please close this issue.

        Show
        johanoskarsson Johan Oskarsson added a comment - I'm assuming the contrib directories should conform to the Hadoop guidelines, if not please close this issue.
        Hide
        asrabkin Ari Rabkin added a comment -

        I'm tempted to starting dealing with this issue fairly soon. Once Chukwa is its own subproject, I was thinking to just do a big automated reformat locally, then commit. Is that unwise? What's the right way to deal with this sort of thing?

        Show
        asrabkin Ari Rabkin added a comment - I'm tempted to starting dealing with this issue fairly soon. Once Chukwa is its own subproject, I was thinking to just do a big automated reformat locally, then commit. Is that unwise? What's the right way to deal with this sort of thing?
        Hide
        cutting Doug Cutting added a comment -

        > What's the right way to deal with this sort of thing?

        Doing it as a single commit in a separate issue is probably best. It unfortunately confuses tools like 'svn blame', making it harder to find the origin of a line of code, but it's better to get it done sooner than later.

        Show
        cutting Doug Cutting added a comment - > What's the right way to deal with this sort of thing? Doing it as a single commit in a separate issue is probably best. It unfortunately confuses tools like 'svn blame', making it harder to find the origin of a line of code, but it's better to get it done sooner than later.
        Hide
        asrabkin Ari Rabkin added a comment -

        Upping priority, since we ought to do this soon or not at all – right now there aren't outstanding patches against the current repository, so we won't break anything. This will get rapidly harder to do once development resumes.

        Show
        asrabkin Ari Rabkin added a comment - Upping priority, since we ought to do this soon or not at all – right now there aren't outstanding patches against the current repository, so we won't break anything. This will get rapidly harder to do once development resumes.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just fixed this. (Discussed with Doug and Owen. No patch here, just a very scary SVN commit.)

        ( It's revision 752666 if we need to back it out later because something broke.)

        Show
        asrabkin Ari Rabkin added a comment - I just fixed this. (Discussed with Doug and Owen. No patch here, just a very scary SVN commit.) ( It's revision 752666 if we need to back it out later because something broke.)

          People

          • Assignee:
            asrabkin Ari Rabkin
            Reporter:
            johanoskarsson Johan Oskarsson
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development