Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2.0
    • Fix Version/s: 0.2.0
    • Component/s: Data Collection
    • Labels:
      None

      Description

      Clean up CollectorStub command-line interface; allow users to specify custom servlets to run alongside Chukwa.

        Activity

        Hide
        Mac Yang added a comment -

        This should get reopened.

        Report from QA,

        java.lang.ArrayIndexOutOfBoundsException: 0
        at org.apache.hadoop.chukwa.datacollection.collector.CollectorStub.main(CollectorStub.java:41)

        Show
        Mac Yang added a comment - This should get reopened. Report from QA, java.lang.ArrayIndexOutOfBoundsException: 0 at org.apache.hadoop.chukwa.datacollection.collector.CollectorStub.main(CollectorStub.java:41)
        Hide
        Hudson added a comment -

        Integrated in Chukwa-trunk #49 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/49/)
        . More flexible CollectorStub

        Show
        Hudson added a comment - Integrated in Chukwa-trunk #49 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/49/ ) . More flexible CollectorStub
        Hide
        Ari Rabkin added a comment -

        I just committed this.

        Note. The patch conflicted in a trivial way with CHUKWA-30. I didn't bother to regenerate the patch, but did merge in the changes. (CHUKWA-30 changed the daemon.setRunning() option, for reasons that aren't clear to me.).

        Show
        Ari Rabkin added a comment - I just committed this. Note. The patch conflicted in a trivial way with CHUKWA-30 . I didn't bother to regenerate the patch, but did merge in the changes. ( CHUKWA-30 changed the daemon.setRunning() option, for reasons that aren't clear to me.).
        Hide
        Ari Rabkin added a comment -

        The patch does indeed break backwards compatibility. It makes / default to /chukwa. The awkwardness for unit testing is that most of the action happens in main(); I suppose I can probably refactor to avoid that.

        I do have code that uses this patch, but it isn't quite commit-ready.

        Show
        Ari Rabkin added a comment - The patch does indeed break backwards compatibility. It makes / default to /chukwa. The awkwardness for unit testing is that most of the action happens in main(); I suppose I can probably refactor to avoid that. I do have code that uses this patch, but it isn't quite commit-ready.
        Hide
        Eric Yang added a comment -

        Could we add custom servlet as a test case?

        It looks like this patch may break the backward compatibility. Is this going to make unspecified URL default to /chukwa? If so, I am ok with this patch.

        Show
        Eric Yang added a comment - Could we add custom servlet as a test case? It looks like this patch may break the backward compatibility. Is this going to make unspecified URL default to /chukwa? If so, I am ok with this patch.
        Hide
        Ari Rabkin added a comment -

        Real motivation here is to allow other custom servlets to run alongside the Chukwa collector for real-time reporting.
        Cleaned-up command-line interface facilitates this, but is useful on its own.

        Show
        Ari Rabkin added a comment - Real motivation here is to allow other custom servlets to run alongside the Chukwa collector for real-time reporting. Cleaned-up command-line interface facilitates this, but is useful on its own.

          People

          • Assignee:
            Ari Rabkin
            Reporter:
            Ari Rabkin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development