Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-215

postProcess.sh should use ${CHUKWA_CONF_DIR} instead of ${CHUKWA_HOME}/conf

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Data Processors
    • Labels:
      None
    • Environment:

      Redhat EL 5.1, Java 6

      Description

      The configuration is loading from incorrect directory if the configuration directory is not in CHUKWA_HOME. This should be changed to use $

      {CHUKWA_CONF_DIR}

      .

      1. CHUKWA-215.patch
        1.0 kB
        Jerome Boulon

        Activity

        Hide
        jboulon Jerome Boulon added a comment -

        I've removed CHUKWA_HOME/conf from the classpath and add CHUKWA_CONF_DIR but
        Everyone should rely on ChukwaConfiguration to get the right configuration, relying only on the classpath may introduce some inconsistencies since there's some additional logic into the ChukwaConfiguration class.

        Show
        jboulon Jerome Boulon added a comment - I've removed CHUKWA_HOME/conf from the classpath and add CHUKWA_CONF_DIR but Everyone should rely on ChukwaConfiguration to get the right configuration, relying only on the classpath may introduce some inconsistencies since there's some additional logic into the ChukwaConfiguration class.
        Hide
        eyang Eric Yang added a comment -

        +1 Looks good.

        Show
        eyang Eric Yang added a comment - +1 Looks good.
        Hide
        eyang Eric Yang added a comment -

        I just committed this, thanks Jerome.

        Show
        eyang Eric Yang added a comment - I just committed this, thanks Jerome.
        Hide
        hudson Hudson added a comment -

        Integrated in Chukwa-trunk #24 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/24/)
        . Corrected postProcess.sh environment setup. (Jerome Boulon via Eric Yang)

        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #24 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/24/ ) . Corrected postProcess.sh environment setup. (Jerome Boulon via Eric Yang)
        Hide
        hudson Hudson added a comment -
        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #45 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/45/ )

          People

          • Assignee:
            jboulon Jerome Boulon
            Reporter:
            eyang Eric Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development