Chukwa
  1. Chukwa
  2. CHUKWA-13

Support SQL macros in Chukwa Charting

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Redhat EL 5.1, Java 6

      Description

      In Chukwa Database aggregator, we could execute SQL statement which looks like:

      insert into [cluster_system_metrics] (select [avg(system_metrics)] from [system_metrics] where timestamp between [past_10_minutes] and [now]);

      This new feature is to bring macro language to HICC charting. The user can write statement like:

      select timestamp,host,load_5 from [system_metrics] where timestamp between [start] and [end];

      This statement will automatically expand to:

      select timestamp, host, load_5 from system_metrics_2045_week where timestamp between '2009-03-02 00:00:00' and '2009-03-03 00:00:00';

        Activity

        Eric Yang created issue -
        Eric Yang made changes -
        Field Original Value New Value
        Assignee Eric Yang [ eyang ]
        Eric Yang made changes -
        Component/s contrib/chukwa [ 12312445 ]
        Hide
        Eric Yang added a comment -
        • Create a new Macro class for macro substitution.
        • Changed Aggregator to use Macro class.
        • Added macro substitution support to Chukwa Charting.
        • Added Macro test case.
        Show
        Eric Yang added a comment - Create a new Macro class for macro substitution. Changed Aggregator to use Macro class. Added macro substitution support to Chukwa Charting. Added Macro test case.
        Eric Yang made changes -
        Attachment HADOOP-5398.patch [ 12401696 ]
        Eric Yang made changes -
        Hadoop Flags [Reviewed]
        Status Open [ 1 ] Patch Available [ 10002 ]
        Release Note What is new in HADOOP-5398:

           - Create a new Macro class for macro substitution.
           - Changed Aggregator to use Macro class.
           - Added macro substitution support to Chukwa Charting.
           - Added Macro test case.
        Owen O'Malley made changes -
        Project Hadoop Core [ 12310240 ] Hadoop Chukwa [ 12310900 ]
        Key HADOOP-5398 CHUKWA-13
        Hadoop Flags [Reviewed]
        Release Note What is new in HADOOP-5398:

           - Create a new Macro class for macro substitution.
           - Changed Aggregator to use Macro class.
           - Added macro substitution support to Chukwa Charting.
           - Added Macro test case.
        Component/s contrib/chukwa [ 12312445 ]
        Hide
        Ari Rabkin added a comment -

        This patch has gone stale; Eric, can you regenerate?

        Show
        Ari Rabkin added a comment - This patch has gone stale; Eric, can you regenerate?
        Ari Rabkin made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Eric Yang added a comment -

        Regenerate patch with updated indentation.

        Show
        Eric Yang added a comment - Regenerate patch with updated indentation.
        Eric Yang made changes -
        Attachment CHUKWA-13.patch [ 12403621 ]
        Eric Yang made changes -
        Attachment HADOOP-5398.patch [ 12401696 ]
        Hide
        Eric Yang added a comment -
        • Create a new Macro class for macro substitution.
        • Changed Aggregator to use Macro class.
        • Added macro substitution support to Chukwa Charting.
        • Added Macro test case.
        Show
        Eric Yang added a comment - Create a new Macro class for macro substitution. Changed Aggregator to use Macro class. Added macro substitution support to Chukwa Charting. Added Macro test case.
        Eric Yang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Eric Yang added a comment -

        Raise priority for 0.1.2 release.

        Show
        Eric Yang added a comment - Raise priority for 0.1.2 release.
        Eric Yang made changes -
        Priority Major [ 3 ] Blocker [ 1 ]
        Hide
        Ari Rabkin added a comment -

        It looks like the Macro class didn't make it into the patch...

        Show
        Ari Rabkin added a comment - It looks like the Macro class didn't make it into the patch...
        Hide
        Ari Rabkin added a comment -

        pending addition of Macro class.

        Show
        Ari Rabkin added a comment - pending addition of Macro class.
        Ari Rabkin made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Eric Yang added a comment -

        add Macro.java into the patch.

        Show
        Eric Yang added a comment - add Macro.java into the patch.
        Eric Yang made changes -
        Attachment CHUKWA-13.patch [ 12404105 ]
        Eric Yang made changes -
        Attachment CHUKWA-13.patch [ 12403621 ]
        Hide
        Eric Yang added a comment -

        Include Macro.java in the patch.

        Show
        Eric Yang added a comment - Include Macro.java in the patch.
        Eric Yang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Eric Yang added a comment -

        I just committed this. Close as resolved.

        Show
        Eric Yang added a comment - I just committed this. Close as resolved.
        Eric Yang made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ari Rabkin added a comment -

        Note that in the future, this should probably come with a modification to CHANGES.txt, and also perhaps a release note.

        Show
        Ari Rabkin added a comment - Note that in the future, this should probably come with a modification to CHANGES.txt, and also perhaps a release note.
        Hide
        Eric Yang added a comment -

        It's recommended by Owen that batching changes and commit CHANGES.txt weekly is better than per jira.
        The changes are tracked in CHANGES.txt.

        Show
        Eric Yang added a comment - It's recommended by Owen that batching changes and commit CHANGES.txt weekly is better than per jira. The changes are tracked in CHANGES.txt.
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        19d 3h 9m 2 Ari Rabkin 27/Mar/09 22:32
        Open Open Patch Available Patch Available
        6d 6h 13m 3 Eric Yang 30/Mar/09 05:42
        Patch Available Patch Available Resolved Resolved
        7m 14s 1 Eric Yang 30/Mar/09 05:49

          People

          • Assignee:
            Eric Yang
            Reporter:
            Eric Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development