Chukwa
  1. Chukwa
  2. CHUKWA-11

conf files with templates should be ignored, not tracked, by SVN

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Files with conf/*.template file should not be tracked by SVN. They should be ignored instead.

      These files were incorrectly added to SVN as part of HADOOP 4792.

      These files include:
      *chukwa-env.sh
      *chukwa-agent-conf.xml
      *chukwa-collector-conf.xml
      *collectors
      *chukwa-demux-conf.xml (a corresponding chukwa-demux.xml.template should be created for this file)

        Issue Links

          Activity

          Hide
          Ari Rabkin added a comment -

          I just fixed this. (no patch, since it's just some svn deletes and propsets.)

          Show
          Ari Rabkin added a comment - I just fixed this. (no patch, since it's just some svn deletes and propsets.)
          Hide
          Ari Rabkin added a comment -

          Should do this now, since we just broke every existing repo doign the move, and people haven't yet started installing and using Chukwa.

          Show
          Ari Rabkin added a comment - Should do this now, since we just broke every existing repo doign the move, and people haven't yet started installing and using Chukwa.
          Hide
          Chris Douglas added a comment -

          Shouldn't they be removed so that an "svn co" from scratch does not include them?

          +1

          Show
          Chris Douglas added a comment - Shouldn't they be removed so that an "svn co" from scratch does not include them? +1
          Hide
          Andy Konwinski added a comment -

          Chris, you are right. I was reading the JIRA/patch incorrectly. The svn:ignore property was actually set for these files with that JIRA/patch. However, the files still appear to be in the SVN repository. e.g. http://svn.apache.org/viewvc/hadoop/core/trunk/src/contrib/chukwa/conf/

          Shouldn't they be removed so that an "svn co" from scratch does not include them?

          Show
          Andy Konwinski added a comment - Chris, you are right. I was reading the JIRA/patch incorrectly. The svn:ignore property was actually set for these files with that JIRA/patch. However, the files still appear to be in the SVN repository. e.g. http://svn.apache.org/viewvc/hadoop/core/trunk/src/contrib/chukwa/conf/ Shouldn't they be removed so that an "svn co" from scratch does not include them?
          Hide
          Chris Douglas added a comment -

          These files were incorrectly added to SVN as part of HADOOP 4792.

          No, they weren't. http://svn.apache.org/viewvc?view=rev&revision=723913

          Show
          Chris Douglas added a comment - These files were incorrectly added to SVN as part of HADOOP 4792. No, they weren't. http://svn.apache.org/viewvc?view=rev&revision=723913
          Hide
          Andy Konwinski added a comment -

          the conf files referrenced were committed as part of HADOOP-4792

          Show
          Andy Konwinski added a comment - the conf files referrenced were committed as part of HADOOP-4792

            People

            • Assignee:
              Ari Rabkin
              Reporter:
              Andy Konwinski
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development