Commons Chain
  1. Commons Chain
  2. CHAIN-42

Various scope mappers use incorrect equalization

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Component/s: None
    • Labels:
      None
    • Environment:

      All

      Description

      The following classes:

      org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
      org.apache.commons.chain.web.portlet.PortletRequestScopeMap
      org.apache.commons.chain.web.portlet.PortletSessionScopeMap
      org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
      org.apache.commons.chain.web.servlet.ServletRequestScopeMap
      org.apache.commons.chain.web.servlet.ServletSessionScopeMap

      use the "==" for comparison in their containsValue(Object) methods. This is in contrary to java.util.Map's specification which mandates that the containsValue(v1) method returns true if and only if there exists a value 'v' in the map such that v1.equals(v).

      1. patch-equals.txt
        5 kB
        Isaac Shabtay

        Activity

        Isaac Shabtay created issue -
        Isaac Shabtay made changes -
        Field Original Value New Value
        Attachment patch-equals.txt [ 12370741 ]
        Niall Pemberton made changes -
        Affects Version/s 1.2 [ 12311963 ]
        Niall Pemberton made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Niall Pemberton [ niallp ]
        Fix Version/s 1.2 [ 12311963 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Niall Pemberton
            Reporter:
            Isaac Shabtay
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development