Commons Chain
  1. Commons Chain
  2. CHAIN-42

Various scope mappers use incorrect equalization

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 1.2
    • Component/s: None
    • Labels:
      None
    • Environment:

      All

      Description

      The following classes:

      org.apache.commons.chain.web.portlet.PortletApplicationScopeMap
      org.apache.commons.chain.web.portlet.PortletRequestScopeMap
      org.apache.commons.chain.web.portlet.PortletSessionScopeMap
      org.apache.commons.chain.web.servlet.ServletApplicationScopeMap
      org.apache.commons.chain.web.servlet.ServletRequestScopeMap
      org.apache.commons.chain.web.servlet.ServletSessionScopeMap

      use the "==" for comparison in their containsValue(Object) methods. This is in contrary to java.util.Map's specification which mandates that the containsValue(v1) method returns true if and only if there exists a value 'v' in the map such that v1.equals(v).

      1. patch-equals.txt
        5 kB
        Isaac Shabtay

        Activity

        Hide
        Isaac Shabtay added a comment -

        Proposed patch. Note that in none of the cases can "value" be null, so an NPE shouldn't happen.

        Show
        Isaac Shabtay added a comment - Proposed patch. Note that in none of the cases can "value" be null, so an NPE shouldn't happen.
        Hide
        Niall Pemberton added a comment -
        Show
        Niall Pemberton added a comment - Fixed, thanks for the patch http://svn.apache.org/viewvc?view=rev&revision=658355

          People

          • Assignee:
            Niall Pemberton
            Reporter:
            Isaac Shabtay
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development