Apache Cordova

Apache Cordova

Source changes - FishEye

Shows the 20 most recent commits for Apache Cordova.

Yann Ylavic committed 1736186 (1 file)
Reviews: none

mod_ssl: return non ambiguous value in ssl_callback_SessionTicket() for
encryption mode (we used to return 0, OpenSSL documents returning 1 instead).

Practically this does not change anything since OpenSSL will only check for
>= 0 return value (non error) for encryption mode (the other possible return
values are only relevant for decryption mode).

However the OpenSSL documentation for SSL_CTX_set_tlsext_ticket_key_cb()
states:
"
The return value of the cb function is used by OpenSSL to determine what
further processing will occur. The following return values have meaning:

2
    This indicates that the ctx and hctx have been set and the session can
    continue on those parameters. Additionally it indicates that the session
    ticket is in a renewal period and should be replaced. The OpenSSL library
    will call cb again with an enc argument of 1 to set the new ticket (see
    RFC5077 3.3 paragraph 2).

1
    This indicates that the ctx and hctx have been set and the session can
    continue on those parameters.

0
    This indicates that it was not possible to set/retrieve a session ticket
    and the SSL/TLS session will continue by by negotiating a set of
    cryptographic parameters or using the alternate SSL/TLS resumption
    mechanism, session ids.
    If called with enc equal to 0 the library will call the cb again to get a
    new set of parameters.

less than 0
    This indicates an error.
"

So 0 is not appropriate in our code, 1 is what we really want (and it won't
break if OpenSSL later changes its checks on the callback return value).

Reported/Proposed by: oknet on github, pull request #18.

Rainer Jung committed 1735883 (6 files)
Reviews: none

Support for OpenSSL 1.1.0:
- The callback function passed to
  SSL_CTX_sess_set_get_cb() now needs the
  session id argument to be const.
  So constify the session id.

Pierre De Rop committed 1731147 (155 files)
Reviews: none

Applied feedbacks that Jan Willem sent to me about the new dm-lambda library:

- renamed the DependencyManagerActivator.activate() method to init(BundleContext ctx, DependencyManager dm)
- Removed abbreviated names like "cb()" or "cbi" methods, and replaced them with niced method names like "add()/changed()/removed()" ...
- Added a system property "org.apache.felix.dependencymanager.lambda.dependencymode" that allows to control the default
mode of dependency (still to be discussed).
- added full support or new configuration types.

felix trunk
Stefan Fuhrmann committed 1730373 (3 files)
Reviews: none

Switch the repos layer's replay functions to new svn_fs_paths_changed3 API.

To do this, we also need a dup function for svn_fs_path_change3_t.

* subversion/include/svn_fs.h
  (svn_fs_path_change3_dup): Declare the new API function.

* subversion/libsvn_fs/fs-loader.c
  (svn_fs_path_change3_dup): Implement it.

* subversion/libsvn_repos/replay.c
  (add_subdir,
   fill_copyfrom,
   path_driver_cb_func): All changes now use the new struct type.
  (get_relevant_changes): Switch to the new API. Be sure to copy the temp
                          data before placing it into the output containers.
  (add_subdir_ev2,
   replay_node): All changes now use the new struct type.

Pierre De Rop committed 1726125 (47 files)
Reviews: none

Made callbacks based on method references more fluent (removed usage of Cb enum for all dependencies except for ComponentBuilder).

felix root:
Pierre De Rop committed 1724333 (89 files)
Reviews: none

Committing my current work. API has been cleaned and "API bloat" has been reduced, using CB enum.

felix root:
Ivan Latysh committed 1721746 (2 files)
Reviews: none

Obtain svn:author and svn:date using one FS call after commit.

* subversion/libsvn_repos/commit.c
* subversion/mod_dav_svn/merge.c
  (invoke_commit_cb, dav_svn__merge_response): Use svn_fs_revision_proplist2()
   to get svn:author and svn:date instead of two calls separate calls to
   svn_fs_revision_prop2().

Bert Huijben committed 1718391 (1 file)
Reviews: none

On the ra-git branch: hook up a bit more auth handling on fetching updates
from a remote git repository.

* subversion/libsvn_ra_git/fetch.c
  (RA_GIT_DEFAULT_REF): Remove as unused.
  (get_username): Use sess directly. Remove obsolete parts of comment.
  (ra_git_remote_baton_t): Add variable.
  (remote_credentials_acquire): Add basic implementation.
  (git_remote_completion_cb): Save credentials.

James Ferguson committed 1716652 (5 files)
Reviews: none

Merge r1711728, r1713209 from trunk:

For the "SSLStaplingReturnResponderErrors off" case, make sure to only
staple responses with certificate status "good". Also avoids including
inaccurate responses when the OCSP responder is not completely up
to date in terms of the CA-issued certificates (and provides interim
"unknown" or "extended revoked" [RFC 6960] status replies).

Log a certificate status other than "good" in stapling_check_response().

Propagate the "ok" status from stapling_check_response() back via both
stapling_renew_response() and get_and_check_cached_response() to the
callback code in stapling_cb(), enabling the decision whether to include
or skip the response.


insert missing LOGNO in ssl_util_stapling.c
Submitted by: kbrand
Reviewed/backported by: jim

kbrand committed 1711728 (3 files)
Reviews: none

For the "SSLStaplingReturnResponderErrors off" case, make sure to only
staple responses with certificate status "good". Also avoids including
inaccurate responses when the OCSP responder is not completely up
to date in terms of the CA-issued certificates (and provides interim
"unknown" or "extended revoked" [RFC 6960] status replies).

Log a certificate status other than "good" in stapling_check_response().

Propagate the "ok" status from stapling_check_response() back via both
stapling_renew_response() and get_and_check_cached_response() to the
callback code in stapling_cb(), enabling the decision whether to include
or skip the response.

Julian Foad committed 1709877 (5 files)
Reviews: none

On the 'move-tracking-2' branch: Remove a premature optimization, the
ability to fetch element payloads from the repository on demand.

Instead, read all payloads in full at start-up. A real implementation
certainly could not afford to work this way, but this will make some other
refactorings easier in the short term.

* subversion/include/private/svn_editor3e.h
  (svn_editor3_payload_resolve,
   svn_editor3_cb_payload_resolve_t,
   svn_editor3_cb_funcs_t): Delete the 'payload_resolve' method.
  (svn_payload_fetch): New.

* subversion/libsvn_delta/compat3e.c
  (svn_payload_fetch): New.
  (editor3_payload_resolve,
   svn_editor3_in_memory,
   svn_editor3__ev3_from_delta_for_commit): Delete the 'payload_resolve'
    method.

* subversion/libsvn_delta/editor3e.c
  (svn_editor3_payload_resolve,
   wrap_payload_resolve,
   svn_editor3__get_debug_editor): Delete the 'payload_resolve' method.

* subversion/libsvn_ra/ra_loader.c
  (txn_fetch_payloads): New.
  (svn_branch_repos_fetch_info,
   svn_branch_get_mutable_state,
   svn_ra_load_branching_state): Fetch payloads.

* subversion/svnmover/svnmover.c
  (element_differences,
   do_put_file,
   do_cat): No longer call 'svn_editor3_payload_resolve'.

Stefan Fuhrmann committed 1708003 (4 files)
Reviews: none

Switch the remaining FS API calls in lib_repos to the latest FS API.

* subversion/libsvn_repos/commit.c
  (invoke_commit_cb): There is no point enabling revprop caching here
                      because it could only speed up a 3rd access while
                      we have only two.

* subversion/libsvn_repos/fs-wrap.c
  (svn_repos_fs_change_rev_prop4,
   svn_repos_fs_revision_prop,
   svn_repos_fs_revision_proplist): These queries perform only a single
                                    revprop read and that needs to return
                                    the latest data.

* subversion/libsvn_repos/rev_hunt.c
  (svn_repos_get_committed_info): Same.

* subversion/libsvn_repos/load-fs-vtable.c
  (close_revision): Same.
  (revprops_close_revision): This one needs to read the latest data.

Julian Foad committed 1706000 (4 files)
Reviews: none

On the 'move-tracking-2' branch: Add a 'branch' method to the editor and use
it instead of direct access to the branch API.

* subversion/include/private/svn_editor3e.h
  (svn_editor3_branch,
   svn_editor3_cb_branch_t): New.
  (svn_editor3_cb_funcs_t): Add the method to the vtable.

* subversion/libsvn_delta/editor3e.c
  (svn_editor3_branch,
   wrap_branch,
   change_detection_branch): New.
  (svn_editor3__get_debug_editor,
   svn_editor3__change_detection_editor): Add the method to the vtable.

* subversion/libsvn_delta/compat3e.c
  (branch_in_rev_or_txn): New, factored out...
  (editor3_copy_tree): ... from here.
  (editor3_branch): New.
  (svn_editor3_in_memory,
   svn_editor3__ev3_from_delta_for_commit): Add the method to the vtable.

* subversion/svnmover/svnmover.c
  (do_branch,
   do_topbranch): Use the method.
  (do_branch_and_delete,
   execute): Track the changes to do_branch() and do_topbranch().

Julian Foad committed 1701445 (6 files)
Reviews: none

On the 'move-tracking-2' branch: Add an editor method 'open_branch'.

This gets rid of some direct access to the editor's txn.

* subversion/include/private/svn_branch.h,
  subversion/libsvn_delta/branch.c
  (svn_branch_id_split): Newly public; renamed from 'branch_id_split'.
  (svn_branch_state_parse): Track the rename.

* subversion/include/private/svn_editor3e.h
  (svn_editor3_open_branch,
   svn_editor3_cb_open_branch_t): New.
  (svn_editor3_cb_funcs_t): Add the new method.

* subversion/libsvn_delta/editor3e.c
  (svn_editor3_open_branch,
   wrap_open_branch,
   change_detection_open_branch): New.
  (svn_editor3__get_debug_editor,
   svn_editor3__change_detection_editor): Add the new method to the vtable.

* subversion/libsvn_delta/compat3e.c
  (editor3_open_branch): New.
  (svn_editor3_in_memory,
   svn_editor3__ev3_from_delta_for_commit): Add it to the vtable.
  (editor3_alter): Move the EID allocation hack to here...

* subversion/svnmover/svnmover.c
  (subtree_replay): ... from here. Take a branch id instead of a pointer.
  (svn_branch_replay): Use the new editor method. Use branch ids instead of
    pointers.
  (replay): Pass a branch id instead of a pointer.
  (mk_branch): Use the new editor method. Return a branch id instead of a
    pointer.
  (execute): Adjust the call to mk_branch.

Julian Foad committed 1697409 (1 file)
Reviews: none

On the 'move-tracking-2' branch: Remove an obsolete type declaration.

* subversion/include/private/svn_editor3e.h
  (svn_editor3_cb_instantiate_t): Remove.

icing committed 1696755 (1 file)
Reviews: none

fixed type of error parameter for invalid_frame_recv_cb callback

Julian Foad committed 1693408 (4 files)
Reviews: none

On the 'move-tracking-2' branch: Change the payload resolver API to populate
the content of the existing payload structure instead of just returning the
content.

* subversion/include/private/svn_editor3e.h
  (svn_editor3_payload_resolve,
   svn_editor3_cb_payload_resolve_t): Remove the output and pool parameters
    and update the doc string.

* subversion/libsvn_delta/editor3e.c
  (svn_editor3_payload_resolve,
   wrap_payload_resolve,
   change_detection_payload_resolve): Remove the output and pool parameters.
  (svn_branch_subtree_differences): Simplify calls accordingly.

* subversion/include/private/svn_element.h
  (svn_element_payload_t): Add a 'pool' field.

* subversion/libsvn_delta/element.c
  (svn_element_payload_create_ref,
   svn_element_payload_create_dir,
   svn_element_payload_create_file,
   svn_element_payload_create_symlink): Initialize the 'pool' field.

Branko Čibej committed 1688395 (4 files)
Reviews: none

Follow up to r1688273:
Minor spelling and documentation fixes, no functional change.

[in subversion/bindings/javahl]

* src/org/apache/subversion/javahl/callback/ReposVerifyCallback.java
  (ReposVerifyCallback.onVerifyError): Fix typo in docstring.

* native/ReposVerifyCallback.h
  (ReposVerifyCallback::m_jverify_cb): Renamed from m_verify_cb.
  (ReposVerifyCallback::ReposVerifyCallback): Add docstring and rename parameter.
  (ReposVerifyCallback::callback): Fix docstring.
* native/ReposVerifyCallback.cpp
  (ReposVerifyCallback::ReposVerifyCallback): Remove docstring. Rename variables.
  (ReposVerifyCallback::onVerifyError): Rename variables.

* tests/org/apache/subversion/javahl/SVNReposTests.java
  (SVNReposTests.VerifyCallback.onVerifyError): Add braces to compound conditional.
  (SVNReposTests.tryToBreakRepo): Renamed from trytobreakrepo. Update callers.
  (SVNReposTests.testVerifyBrokenRepo,
   SVNReposTests.testVerifyBrokenRepo_KeepGoing): Make the test setup more explicit.

Julian Foad committed 1683383 (4 files)
Reviews: none

On the 'move-tracking-2' branch: Make 'payload_resolve' an editor virtual
method.

I am not sure if the editor eventually will need to provide this, or
something like it, but for now it is useful. And it was worse, previously,
to have this as a non-virtual function, because then editors could not
successfully be chained. Now there are no non-virtual methods.

* subversion/include/private/svn_editor3e.h
  (svn_editor3_cb_payload_resolve_t): New.
  (svn_editor3_cb_funcs_t): Add the method.
  (svn_editor3_payload_resolve): Tweak the function signature as required
    for editor methods.

* subversion/libsvn_delta/compat3e.c
  (editor3_payload_resolve): Rename from 'svn_editor3_payload_resolve' and
    make static.
  (svn_editor3_in_memory,
   svn_editor3__ev3_from_delta_for_commit): Add the method to the vtable.

* subversion/libsvn_delta/editor3e.c
  (svn_editor3_payload_resolve,
   wrap_payload_resolve): New.
  (svn_editor3__get_debug_editor): Add the method to the vtable.
  (svn_branch_subtree_differences): Tweak callers accordingly.

* subversion/svnmover/svnmover.c
  (wc_commit): Display the diff after the commit has completed, rather than
    inside the commit callback, so as not to nest calls to payload_resolve
    inside the editor complete() method, as the editor framework forbids
    nesting.
  (commit_callback): Don't display the diff here.
  (display_diff_of_commit): New.