[CB-9990] Plugin build extras is no longer working in 5.4.0

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.4.1
• Fix Version/s: 5.0.0
• Component/s: cordova-android, cordova-lib
• Labels: Android

Environment

Mac (El Capitan)

• Assignee: Steve Gill
• Reporter: Ross Cullen
• Created: 13/Nov/15 10:16
• Updated: 23/Aug/18 06:52
• Resolved: 12/Jan/16 22:20

Description

Following the "Extending build.gradle" guide:
https://cordova.apache.org/docs/en/edge/guide/platforms/android/tools.html

We have been using the build-extras.gradle functionality in our custom plugin since 5.0.0 and it's been working great. With <framework src="some.gradle" custom="true" type="gradleReference" /> in the plugin.xml.

It inserts the script into
// PLUGIN GRADLE EXTENSIONS START
apply from: "<plugin>/app-build-extras.gradle"
// PLUGIN GRADLE EXTENSIONS END

Upgrading to 5.4.0 and this functionality seems to be gone.
i.e. the above line is blank after a rebuild

// PLUGIN GRADLE EXTENSIONS START
// PLUGIN GRADLE EXTENSIONS END