[CB-9743] Plugin items do not added properly to xcode project on ios platform

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Master
• Fix Version/s: 0.1.0
• Component/s: cordova-common
• Assignee: Vladimir Kotikov
• Reporter: Vladimir Kotikov
• Created: 05/Oct/15 09:37
• Updated: 06/Oct/15 09:32
• Resolved: 06/Oct/15 09:32

Description

There is the tests failures on OS X using 'cordova-common' module , caused by PlatformApi refactoring and it seems they caused by double caching of ios pbxproj files: first time in ios_parser [1] and second time in PlatformMunger (through ConfigKeeper class) [2], [3]. It seems that at some time one file get cached twice and then saving one cached instance we’re overwriting changes, saved from another cache.

[1] https://github.com/MSOpenTech/cordova-lib/blob/master/cordova-lib/src/plugman/platforms/ios.js#L210
[2] https://github.com/MSOpenTech/cordova-lib/blob/master/cordova-common/src/ConfigChanges/ConfigChanges.js#L91
[3] https://github.com/MSOpenTech/cordova-lib/blob/master/cordova-common/src/ConfigChanges/ConfigKeeper.js#L47

Issue Links

• is part of: CB-9598 Factor out shared logic to cordova-common module and publish it separately.
• links to: Proposed fix