[CB-9519] Inappropriate destruction time of engine in CordovaWebViewImpl

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Incomplete
• Component/s: cordova-android
• Assignee: Unassigned
• Reporter: Dong Hanlin
• Created: 20/Aug/15 05:52
• Updated: 23/Aug/18 06:51
• Resolved: 30/Jan/17 22:29

Description

In CordovaWebViewImpl.java, one of the TODO comments in public void handleDestroy() method points out that the engine should not destroy webview until after about:blank is done loading. Actually, the engine has indeed been destroyed before about:blank is completely loaded, which causes some problems.

I think moving a line of code may work:

engine.destroy();

This code can be moved into the last if block in public void onPageFinishedLoading(String url), like this:

            // Shutdown if blank loaded
            if (url.equals("about:blank")) {
                engine.destroy();
                pluginManager.postMessage("exit", null);
            }

Since before destroying the engine, we have set the URL to be about:blank, so destroying it when about:blank is completed loaded can work.